[PROF-10679] Fixes for comments from PR 3984 #3987
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As Alex pointed out, using `Qnil` as a marker for uninitialized and `Qfalse` for failed to initialize is a bit of a footgun since it's a very subtle detail. To make it more obvious, I've changed this to `Qtrue` for uninitialized and `Qnil` for failed to initialize, which hopefully is way harder to confuse.
This avoids redundancy in `otel_without_ddtrace_trace_identifiers_for` and simplifies one of our most complex functions for supporting otel.
…gs definition This way users of the setting don't actually need to care about this.
ivoanjo
added
profiling
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3987 +/- ##
==========================================
+ Coverage 97.82% 97.84% +0.01%
==========================================
Files 1314 1314
Lines 78648 78637 -11
Branches 3909 3906 -3
==========================================
+ Hits 76937 76939 +2
+ Misses 1711 1698 -13 ☔ View full report in Codecov by Sentry. |
BenchmarksBenchmark execution time: 2024-10-10 13:35:37 Comparing candidate commit 222b4d4 in PR branch Found 0 performance improvements and 1 performance regressions! Performance is the same for 22 metrics, 2 unstable metrics. scenario:profiler - sample timeline=false
|
AlexJF
approved these changes
Oct 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR gathers fixes for review comments from PR #3984 . See individual commit messages and/or comments in that PR for details.
Motivation:
Since these comments did not impact the feature, and we wanted to get it merged ASAP, I merged that PR first, and here's the follow-up PR to address the comments.
Additional Notes:
N/A
How to test the change?
These features already had test coverage, and this PR tweaks it as needed.