[PROF-10603] Upgrade to libdatadog 13.1 #3997
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ivoanjo
added a commit
to DataDog/libdatadog
that referenced
this pull request
Oct 14, 2024
**What does this PR do?** This PR includes the changes documented in the "Releasing a new version to rubygems.org" part of the README: https://github.com/datadog/libdatadog/tree/main/ruby#releasing-a-new-version-to-rubygemsorg **Motivation:** Enable Ruby to use libdatadog v13.1.0. **Additional Notes:** We ended up not releasing 13.0 for Ruby. I don't see any reason to backfill so I've skipped ahead. **How to test the change?** I've tested this release locally using the changes in DataDog/dd-trace-rb#3997 . As a reminder, new libdatadog releases don't get automatically picked up by dd-trace-rb, so the PR that bumps the Ruby profiler will also test this release against all supported Ruby versions.
**What does this PR do?** This PR upgrades the datadog gem to use libdatadog 13.1. There were no needed API changes, it's a drop-in upgrade. **Motivation:** Staying on the latest libdatadog enables us to pick up the latest improvements and also makes it easier to develop new features that need libdatadog changes. **Additional Notes:** As usual, I'm opening this PR as a draft as libdatadog 13.1 is not yet available on rubygems.org, and I'll come back to re-trigger CI and mark this as non-draft once it is. **How to test the change?** Our existing test coverage includes libdatadog testing, so a green CI is good here :)
ivoanjo
force-pushed
the
ivoanjo/prof-10603-libdatadog13_1-upgrade
branch
from
b31ccb5 to
c3747a9
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3997 +/- ##
==========================================
- Coverage 97.87% 97.87% -0.01%
==========================================
Files 1314 1314
Lines 78641 78641
Branches 3906 3906
==========================================
- Hits 76971 76969 -2
- Misses 1670 1672 +2 ☔ View full report in Codecov by Sentry. |
BenchmarksBenchmark execution time: 2024-10-14 14:03:15 Comparing candidate commit 720cc5c in PR branch Found 0 performance improvements and 3 performance regressions! Performance is the same for 21 metrics, 2 unstable metrics. scenario:profiler - gvl benchmark samples
scenario:profiler - sample timeline=false
scenario:profiler - stack collector
|
p-datadog
approved these changes
Oct 15, 2024
|
Merging ahead! I spotted that there's potential performance regressions -- I'll keep an eye for the performance in our real-world apps, as they're usually more reliable than our microbenchmarks. |
ivoanjo
added
core
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR upgrades the datadog gem to use libdatadog 13.1.
There were no needed API changes, it's a drop-in upgrade.
Motivation:
Staying on the latest libdatadog enables us to pick up the latest improvements and also makes it easier to develop new features that need libdatadog changes.
Additional Notes:
As usual, I'm opening this PR as a draft as libdatadog 13.1 is not yet available on rubygems.org, and I'll come back to re-trigger CI and mark this as non-draft once it is.
How to test the change?
Our existing test coverage includes libdatadog testing, so a green CI is good here :)