-
Notifications
You must be signed in to change notification settings - Fork 373
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix resource name when Grape paths contain a leading slash #4033
Fix resource name when Grape paths contain a leading slash #4033
Conversation
81a501f
to
e845ee7
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4033 +/- ##
==========================================
- Coverage 97.82% 97.82% -0.01%
==========================================
Files 1327 1327
Lines 79698 79717 +19
Branches 3952 3953 +1
==========================================
+ Hits 77968 77983 +15
- Misses 1730 1734 +4 ☔ View full report in Codecov by Sentry. |
e845ee7
to
a2d62c3
Compare
a2d62c3
to
9f46b17
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍🏼
Thanks for your time 💟
We need to verify that |
Hey @jethrodaniel thanks for your contribution. This change was released as a part of v2.5.0 release. 🎉 |
What does this PR do?
Fix an issue where a Grape resource like this
results in a resource
TestingAPI GET //path/with/leading/slash
, when it should result inTestingAPI GET /path/with/leading/slash
.Motivation:
Seeing the resource name have an unnecessary leading slash.
Change log entry
Fix resource name when Grape paths contain a leading slash
Additional Notes:
How to test the change?