DEBUG-2334 DI benchmarks extracted from #4012 #4049
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These contain code for line probes and method probes, only method probes are currently enabled becuase more DI code is needed to have line probes work.
![datadog-datadog-prod-us1[bot]](https://avatars.githubusercontent.com/u/365230?s=60&v=4){kind=small}
p-datadog
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4049 +/- ##
==========================================
- Coverage 97.79% 97.78% -0.01%
==========================================
Files 1337 1338 +1
Lines 80231 80245 +14
Branches 4014 4014
==========================================
+ Hits 78458 78465 +7
- Misses 1773 1780 +7 ☔ View full report in Codecov by Sentry. |
TonyCTHsu
approved these changes
Oct 30, 2024
BenchmarksBenchmark execution time: 2024-10-30 13:49:46 Comparing candidate commit 5a6a098 in PR branch Found 1 performance improvements and 3 performance regressions! Performance is the same for 25 metrics, 2 unstable metrics. scenario:method instrumentation
scenario:profiler - estimated profiler gc per minute (sample 60000 times + serialize result)
scenario:profiler - profiler gc
scenario:tracing - Propagation - Trace Context
|
p-datadog
added
the
dev/internal
p-datadog
pushed a commit
to p-datadog/dd-trace-rb
that referenced
this pull request
Nov 1, 2024
* master: (25 commits) lint update method fix unix path regex add back mixed_http_and_uds fix test update tests to match this new world order use uds Fix Intel case Purge circleci cache Udpate ffi to 1.17 for gemfiles/*lock Pin version across rubies Fix labeler Pin bundler version Improve naming for persistent_data arg for appsec waf [🤖] Lock Dependency: https://github.com/DataDog/dd-trace-rb/actions/runs/11611017851 Update libddwaf gem to v1.15.0.0.0 Add musl keys Reduce requirement to 2.27 Implement requirement.json DEBUG-2334 DI benchmarks extracted from DataDog#4012 (DataDog#4049) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
The benchmarks in this PR contain code for line probes and method probes, only method probes are currently enabled becuase more DI code is needed to have line probes work.
Motivation:
Change log entry
None
Additional Notes:
This entire PR was part of #4012 but benchmarks were failing there because master (baseline) didn't have enough DI code to run the benchmarks.
How to test the change?
CI