Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEBUG-2334 disable flaky DI specs #4050

Merged
merged 1 commit into from
Oct 30, 2024
Merged

DEBUG-2334 disable flaky DI specs #4050

merged 1 commit into from
Oct 30, 2024

Conversation

p-datadog
Copy link
Member

What does this PR do?

Disables flaky DI specs

Motivation:

Stable CI

Change log entry
None

Additional Notes:

How to test the change?

@p-datadog p-datadog requested a review from a team as a code owner October 30, 2024 13:11
@p-datadog p-datadog changed the title disable flaky DI specs DEBUG-2334 disable flaky DI specs Oct 30, 2024
@TonyCTHsu TonyCTHsu added the dev/testing Involves testing processes (e.g. RSpec) label Oct 30, 2024
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.73%. Comparing base (fe0c0f2) to head (88911f0).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4050      +/-   ##
==========================================
- Coverage   97.79%   97.73%   -0.06%     
==========================================
  Files        1337     1337              
  Lines       80231    80231              
  Branches     4014     4014              
==========================================
- Hits        78458    78416      -42     
- Misses       1773     1815      +42     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pr-commenter
Copy link

pr-commenter bot commented Oct 30, 2024

Benchmarks

Benchmark execution time: 2024-10-30 13:48:18

Comparing candidate commit 88911f0 in PR branch di-flaky-test with baseline commit fe0c0f2 in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 24 metrics, 2 unstable metrics.

@p-datadog p-datadog merged commit f05bd08 into master Oct 30, 2024
273 of 274 checks passed
@p-datadog p-datadog deleted the di-flaky-test branch October 30, 2024 14:33
@p-datadog p-datadog added the dev/internal Other internal work that does not need to be included in the changelog label Oct 30, 2024
@github-actions github-actions bot added this to the 2.5.0 milestone Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev/internal Other internal work that does not need to be included in the changelog dev/testing Involves testing processes (e.g. RSpec)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants