Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CircleCI cache fix #4102

Merged
merged 6 commits into from
Nov 12, 2024
Merged

CircleCI cache fix #4102

merged 6 commits into from
Nov 12, 2024

Conversation

TonyCTHsu
Copy link
Contributor

@TonyCTHsu TonyCTHsu commented Nov 12, 2024

Motivation:

CircleCI cache is corrupted. Running bundle exec appraisal install would return a false negative result that dependencies are still missing.

For example: https://app.circleci.com/pipelines/github/DataDog/dd-trace-rb/17478/workflows/d773b359-cf13-4438-821d-150202473ba3

The bundle cache is around 50 mb (a complete cache size should be around 250 mb) and the missing dependencies are install with a fallback (from previous commit ) when running in the task

What does this PR do?

  1. Replace the broken bundle exec appraisal install with bundle exec rake dependency:install
  2. Adding gemfiles/*.gemfile into bundle checksum
  3. Other minor improvements

@TonyCTHsu TonyCTHsu marked this pull request as ready for review November 12, 2024 10:50
@TonyCTHsu TonyCTHsu requested a review from a team as a code owner November 12, 2024 10:50
Copy link
Member

@Strech Strech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏼

@TonyCTHsu TonyCTHsu merged commit 18960b5 into master Nov 12, 2024
266 of 267 checks passed
@TonyCTHsu TonyCTHsu deleted the tonycthsu/remove-appraisal-update branch November 12, 2024 11:49
@TonyCTHsu TonyCTHsu added the dev/ci Involves CircleCI, GitHub Actions, or GitLab label Nov 12, 2024
@github-actions github-actions bot added this to the 2.7.0 milestone Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev/ci Involves CircleCI, GitHub Actions, or GitLab
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants