Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace Bundler.with_clean_env with Bundler.with_unbundled_env #4104

Merged
merged 3 commits into from
Nov 12, 2024

Conversation

TonyCTHsu
Copy link
Contributor

What does this PR do?

Clear deprecation warnings:

[DEPRECATED] `Bundler.with_clean_env` has been deprecated in favor of `Bundler.with_unbundled_env`. If you instead want the environment before bundler was originally loaded, use `Bundler.with_original_env` (called at /app/spec/datadog/core/environment/execution_spec.rb:190)

@TonyCTHsu TonyCTHsu requested a review from a team as a code owner November 12, 2024 13:49
@github-actions github-actions bot added the dev/testing Involves testing processes (e.g. RSpec) label Nov 12, 2024
@pr-commenter
Copy link

pr-commenter bot commented Nov 12, 2024

Benchmarks

Benchmark execution time: 2024-11-12 15:29:24

Comparing candidate commit 65847a8 in PR branch tonycthsu/remove-with_clean_env with baseline commit 18960b5 in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 29 metrics, 2 unstable metrics.

@codecov-commenter
Copy link

codecov-commenter commented Nov 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.73%. Comparing base (54a779e) to head (1ff92fb).
Report is 12 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4104      +/-   ##
==========================================
- Coverage   97.74%   97.73%   -0.01%     
==========================================
  Files        1341     1341              
  Lines       80356    80356              
  Branches     4030     4030              
==========================================
- Hits        78541    78535       -6     
- Misses       1815     1821       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@sarahchen6 sarahchen6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

@TonyCTHsu TonyCTHsu merged commit 53607b3 into master Nov 12, 2024
260 of 262 checks passed
@TonyCTHsu TonyCTHsu deleted the tonycthsu/remove-with_clean_env branch November 12, 2024 15:57
@github-actions github-actions bot added this to the 2.7.0 milestone Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev/testing Involves testing processes (e.g. RSpec)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants