DEBUG-2334 require file presence for line probe #4105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While testing manually I encountered an exception due to a line probe missing the file. This should not happen and such a configuration is not usable since we don't know which file to instrument. Add extra guards and a unit test to handle this case.
p-datadog
force-pushed
the
di-line-probe-without-file
branch
from
6313753 to
659096c
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4105 +/- ##
==========================================
+ Coverage 97.74% 97.80% +0.05%
==========================================
Files 1341 1341
Lines 80356 80416 +60
Branches 4030 4050 +20
==========================================
+ Hits 78541 78647 +106
+ Misses 1815 1769 -46 ☔ View full report in Codecov by Sentry. |
BenchmarksBenchmark execution time: 2024-11-12 16:52:22 Comparing candidate commit 659096c in PR branch Found 0 performance improvements and 1 performance regressions! Performance is the same for 28 metrics, 2 unstable metrics. scenario:method instrumentation
|
p-datadog
added
the
dev/internal
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds checks that a line probe contains a file, which is required to instrument such a probe.
Motivation:
While testing manually I encountered an exception due to a line probe missing the file. This should not happen and such a configuration is not usable since we don't know which file to instrument. Add extra guards and a unit test to handle this case.
Change log entry
None
Additional Notes:
How to test the change?
Unit tests