ignore - testing deprecation #4117
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BenchmarksBenchmark execution time: 2024-11-14 21:55:27 Comparing candidate commit 08ddf6f in PR branch Found 1 performance improvements and 0 performance regressions! Performance is the same for 28 metrics, 2 unstable metrics. scenario:profiler - sample timeline=false
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR clears the method
raise_on_rails_deprecation!in the filespec/datadog/tracing/contrib/rails/support/deprecation.rb.Motivation:
While implementing Ruby 3.4 testing for CI, we encountered issues with
ActiveRecord::Deprecation. See changes made in #4114 for more details. The intention of this PR is to see how raising no deprecation exceptions will affect the test suite.Change log entry
No change log entry.
Additional Notes:
Based on the results, it seems like the deprecation behavior is not tested.
How to test the change?
CI.