Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix system-tests CI flakiness by adding Dockerhub login #4119

Merged
merged 1 commit into from
Nov 15, 2024

Conversation

vpellan
Copy link
Contributor

@vpellan vpellan commented Nov 15, 2024

What does this PR do?
Fix system-tests CI flakiness by adding Dockerhub login

Motivation:

Docker has a rate limit based on your IP when you docker pull without being logged. This limit is pretty low. If you make the same command, but being authenticated before, the rate limit docker applies is way higher.

Change log entry
None.

Additional Notes:
Variables added as repository secrets.

How to test the change?
I suppose that you could launch system-tests GH workflow a lot of time and see that it does not fail because of dockerhub rate limit

@vpellan vpellan requested a review from a team as a code owner November 15, 2024 14:30
@github-actions github-actions bot added the dev/github Github repository maintenance and automation label Nov 15, 2024
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.77%. Comparing base (ce1a178) to head (a034184).
Report is 12 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4119      +/-   ##
==========================================
- Coverage   97.77%   97.77%   -0.01%     
==========================================
  Files        1350     1350              
  Lines       81077    81150      +73     
  Branches     4085     4087       +2     
==========================================
+ Hits        79275    79344      +69     
- Misses       1802     1806       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pr-commenter
Copy link

pr-commenter bot commented Nov 15, 2024

Benchmarks

Benchmark execution time: 2024-11-15 15:05:38

Comparing candidate commit a034184 in PR branch vpellan/ci-docker-login with baseline commit 6f4db56 in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 29 metrics, 2 unstable metrics.

@vpellan vpellan merged commit 09cc6dc into master Nov 15, 2024
267 checks passed
@vpellan vpellan deleted the vpellan/ci-docker-login branch November 15, 2024 15:29
@github-actions github-actions bot added this to the 2.8.0 milestone Nov 15, 2024
@p-datadog p-datadog added the dev/internal Other internal work that does not need to be included in the changelog label Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev/github Github repository maintenance and automation dev/internal Other internal work that does not need to be included in the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants