Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove rexml from dependencies #4131

Merged
merged 3 commits into from
Nov 19, 2024
Merged

Remove rexml from dependencies #4131

merged 3 commits into from
Nov 19, 2024

Conversation

TonyCTHsu
Copy link
Contributor

What does this PR do?

Remove rexml, no longer required after lockfiles are up-to-date.

@TonyCTHsu TonyCTHsu requested a review from a team as a code owner November 18, 2024 21:33
@TonyCTHsu TonyCTHsu added the dev/internal Other internal work that does not need to be included in the changelog label Nov 18, 2024
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.78%. Comparing base (672f309) to head (77fffc4).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4131   +/-   ##
=======================================
  Coverage   97.77%   97.78%           
=======================================
  Files        1350     1350           
  Lines       81278    81277    -1     
  Branches     4108     4108           
=======================================
+ Hits        79471    79478    +7     
+ Misses       1807     1799    -8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@pr-commenter
Copy link

pr-commenter bot commented Nov 18, 2024

Benchmarks

Benchmark execution time: 2024-11-18 22:12:01

Comparing candidate commit 77fffc4 in PR branch tonycthsu/remove-rexml with baseline commit 672f309 in branch master.

Found 3 performance improvements and 0 performance regressions! Performance is the same for 28 metrics, 2 unstable metrics.

scenario:line instrumentation - targeted

  • 🟩 throughput [+17723.061op/s; +18386.662op/s] or [+9.216%; +9.561%]

scenario:method instrumentation

  • 🟩 throughput [+20246.094op/s; +21274.993op/s] or [+9.670%; +10.162%]

scenario:tracing - Propagation - Datadog

  • 🟩 throughput [+2304.822op/s; +2404.250op/s] or [+7.612%; +7.940%]

@TonyCTHsu TonyCTHsu enabled auto-merge November 19, 2024 00:08
@TonyCTHsu TonyCTHsu merged commit 722f487 into master Nov 19, 2024
287 checks passed
@TonyCTHsu TonyCTHsu deleted the tonycthsu/remove-rexml branch November 19, 2024 08:51
@github-actions github-actions bot added this to the 2.8.0 milestone Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev/internal Other internal work that does not need to be included in the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants