Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update libddwaf to 1.18.0.0.0 #4164

Merged
merged 3 commits into from
Nov 27, 2024
Merged

Update libddwaf to 1.18.0.0.0 #4164

merged 3 commits into from
Nov 27, 2024

Conversation

y9v
Copy link
Member

@y9v y9v commented Nov 26, 2024

Libddwaf 1.18.0.0.0 had some breaking changes - actions in the result is now an array of objects, instead of an array of strings.

Please don't merge until 2.8.0 is released

What does this PR do?
This PR updates libddwaf dependency to 1.18.0.0.0 and fixes specs that were broken with this update.

Motivation:
This version of libddwaf is required for detecting SQL injections.

Change log entry
None

Additional Notes:
None

How to test the change?
CI is enough

@y9v y9v self-assigned this Nov 26, 2024
@github-actions github-actions bot added the appsec Application Security monitoring product label Nov 26, 2024
@y9v y9v force-pushed the update-libddwaf-to-1-18 branch from 83c82c1 to e21459e Compare November 26, 2024 14:46
@pr-commenter
Copy link

pr-commenter bot commented Nov 26, 2024

Benchmarks

Benchmark execution time: 2024-11-26 15:39:21

Comparing candidate commit aa72633 in PR branch update-libddwaf-to-1-18 with baseline commit ce4393e in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 31 metrics, 2 unstable metrics.

@y9v y9v marked this pull request as ready for review November 26, 2024 15:12
@y9v y9v requested review from a team as code owners November 26, 2024 15:12
Copy link
Member

@ivoanjo ivoanjo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Left two "just-in-case-check/questions", otherwise it LGTM

lib/datadog/appsec/event.rb Show resolved Hide resolved
datadog.gemspec Show resolved Hide resolved
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.78%. Comparing base (ce4393e) to head (aa72633).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4164   +/-   ##
=======================================
  Coverage   97.78%   97.78%           
=======================================
  Files        1353     1353           
  Lines       81817    81820    +3     
  Branches     4145     4145           
=======================================
+ Hits        80001    80009    +8     
+ Misses       1816     1811    -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@Strech Strech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome 👏🏼

@y9v y9v merged commit bbee6be into master Nov 27, 2024
300 checks passed
@y9v y9v deleted the update-libddwaf-to-1-18 branch November 27, 2024 10:25
@github-actions github-actions bot added this to the 2.8.0 milestone Nov 27, 2024
@ivoanjo ivoanjo mentioned this pull request Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
appsec Application Security monitoring product
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants