Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean Ruby 3.4 Gemfile #4209

Merged
merged 3 commits into from
Dec 11, 2024
Merged

Clean Ruby 3.4 Gemfile #4209

merged 3 commits into from
Dec 11, 2024

Conversation

sarahchen6
Copy link
Contributor

What does this PR do?
This PR removes if statements and alphabetizes ruby-3.4.gemfile.

Motivation:
Since the gemfiles are no longer symlinked, we can begin removing if statements and generally cleaning each file.

Change log entry
None.

Additional Notes:
N/A

How to test the change?
Green CI.

@sarahchen6 sarahchen6 marked this pull request as ready for review December 9, 2024 18:22
@sarahchen6 sarahchen6 requested a review from a team as a code owner December 9, 2024 18:22
@codecov-commenter
Copy link

codecov-commenter commented Dec 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.76%. Comparing base (1be0c46) to head (47ff27c).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4209   +/-   ##
=======================================
  Coverage   97.76%   97.76%           
=======================================
  Files        1357     1357           
  Lines       82130    82130           
  Branches     4174     4174           
=======================================
  Hits        80298    80298           
  Misses       1832     1832           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pr-commenter
Copy link

pr-commenter bot commented Dec 9, 2024

Benchmarks

Benchmark execution time: 2024-12-11 16:04:25

Comparing candidate commit 47ff27c in PR branch sarahchen6/clean-3.4-gemfile with baseline commit 1be0c46 in branch master.

Found 0 performance improvements and 4 performance regressions! Performance is the same for 27 metrics, 2 unstable metrics.

scenario:profiler - sample timeline=false

  • 🟥 throughput [-0.585op/s; -0.577op/s] or [-8.854%; -8.736%]

scenario:tracing - 100 span trace - no writer

  • 🟥 throughput [-20.489op/s; -19.637op/s] or [-5.857%; -5.613%]

scenario:tracing - Propagation - Datadog

  • 🟥 throughput [-3468.454op/s; -3381.267op/s] or [-10.432%; -10.170%]

scenario:tracing - Tracing.log_correlation

  • 🟥 throughput [-7007.826op/s; -6655.818op/s] or [-5.901%; -5.604%]

@sarahchen6 sarahchen6 force-pushed the sarahchen6/clean-3.4-gemfile branch from 8c32fb8 to 2bed1f1 Compare December 11, 2024 15:33
@datadog-datadog-prod-us1
Copy link
Contributor

datadog-datadog-prod-us1 bot commented Dec 11, 2024

Datadog Report

Branch report: sarahchen6/clean-3.4-gemfile
Commit report: 47ff27c
Test service: dd-trace-rb

✅ 0 Failed, 22065 Passed, 1458 Skipped, 5m 7.35s Total Time

@sarahchen6 sarahchen6 merged commit d87c294 into master Dec 11, 2024
349 checks passed
@sarahchen6 sarahchen6 deleted the sarahchen6/clean-3.4-gemfile branch December 11, 2024 20:27
@github-actions github-actions bot added this to the 2.9.0 milestone Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants