-
Notifications
You must be signed in to change notification settings - Fork 373
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Core::Telemetry stacktrace and error logging #4220
Conversation
Datadog ReportBranch report: ✅ 0 Failed, 22073 Passed, 1457 Skipped, 5m 37.59s Total Time |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4220 +/- ##
=======================================
Coverage 97.76% 97.76%
=======================================
Files 1357 1357
Lines 82130 82131 +1
Branches 4174 4174
=======================================
+ Hits 80292 80293 +1
Misses 1838 1838 ☔ View full report in Codecov by Sentry. |
BenchmarksBenchmark execution time: 2024-12-11 15:22:35 Comparing candidate commit 66aec5f in PR branch Found 1 performance improvements and 0 performance regressions! Performance is the same for 30 metrics, 2 unstable metrics. scenario:profiler - sample timeline=false
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe I need this fix for DI as well, therefore I will be able to test it once it's merged.
I approve the diff but does this PR really not need a change log entry?
Yes, it doesn't. It's an internal Telemetry logger and it's not customer facing code. It's easy to confuse with OpenTelemetry, but it's a different beast. |
What does this PR do?
Correct internal Telemetry logging stacktrace and error name reporting.
Motivation:
Without that change stacktrace doesn't show up correctly which also leads to ErrorTracking being impossible. In addition an extra space added between Error name and description.
Change log entry
No.
Additional Notes:
How to test the change?
CI and ErrorTracking example