Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Core::Telemetry stacktrace and error logging #4220

Merged
merged 1 commit into from
Dec 11, 2024

Conversation

Strech
Copy link
Member

@Strech Strech commented Dec 11, 2024

What does this PR do?

Correct internal Telemetry logging stacktrace and error name reporting.

Motivation:

Without that change stacktrace doesn't show up correctly which also leads to ErrorTracking being impossible. In addition an extra space added between Error name and description.

Change log entry

No.

Additional Notes:

Screenshot 2024-12-11 at 16 00 56

How to test the change?

CI and ErrorTracking example

@Strech Strech requested a review from a team as a code owner December 11, 2024 15:01
@github-actions github-actions bot added the core Involves Datadog core libraries label Dec 11, 2024
@Strech Strech added the dev/internal Other internal work that does not need to be included in the changelog label Dec 11, 2024
@datadog-datadog-prod-us1
Copy link
Contributor

datadog-datadog-prod-us1 bot commented Dec 11, 2024

Datadog Report

Branch report: fix-telemetry-error-reporting
Commit report: 66aec5f
Test service: dd-trace-rb

✅ 0 Failed, 22073 Passed, 1457 Skipped, 5m 37.59s Total Time

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.76%. Comparing base (b6fe8c0) to head (66aec5f).
Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4220   +/-   ##
=======================================
  Coverage   97.76%   97.76%           
=======================================
  Files        1357     1357           
  Lines       82130    82131    +1     
  Branches     4174     4174           
=======================================
+ Hits        80292    80293    +1     
  Misses       1838     1838           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pr-commenter
Copy link

pr-commenter bot commented Dec 11, 2024

Benchmarks

Benchmark execution time: 2024-12-11 15:22:35

Comparing candidate commit 66aec5f in PR branch fix-telemetry-error-reporting with baseline commit b6fe8c0 in branch master.

Found 1 performance improvements and 0 performance regressions! Performance is the same for 30 metrics, 2 unstable metrics.

scenario:profiler - sample timeline=false

  • 🟩 throughput [+0.507op/s; +0.518op/s] or [+8.390%; +8.584%]

Copy link
Member

@p-datadog p-datadog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe I need this fix for DI as well, therefore I will be able to test it once it's merged.

I approve the diff but does this PR really not need a change log entry?

@Strech
Copy link
Member Author

Strech commented Dec 11, 2024

I approve the diff but does this PR really not need a change log entry?

Yes, it doesn't. It's an internal Telemetry logger and it's not customer facing code. It's easy to confuse with OpenTelemetry, but it's a different beast.

@Strech Strech merged commit 85e84bc into master Dec 11, 2024
343 of 344 checks passed
@Strech Strech deleted the fix-telemetry-error-reporting branch December 11, 2024 16:09
@github-actions github-actions bot added this to the 2.9.0 milestone Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Involves Datadog core libraries dev/internal Other internal work that does not need to be included in the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants