[NO-TICKET] Extract spec for binary setting #4224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
**What does this PR do?** This PR introduces a single shared example to replace approximately ONE BILLION copy pasted test cases to test a binary setting that can be read from an env variable. **Motivation:** I've gotten tired of copy-pasting this again and again and decided to finally clean this up. **Additional Notes:** My only regret is not having cleaned this up earlier. **How to test the change?** Validate tests still pass.
ivoanjo
added
dev/testing
Datadog ReportBranch report: ✅ 0 Failed, 22089 Passed, 1458 Skipped, 5m 24.53s Total Time |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4224 +/- ##
==========================================
- Coverage 97.75% 97.75% -0.01%
==========================================
Files 1355 1355
Lines 82165 82010 -155
Branches 4207 4207
==========================================
- Hits 80321 80167 -154
+ Misses 1844 1843 -1 ☔ View full report in Codecov by Sentry. |
BenchmarksBenchmark execution time: 2024-12-13 18:04:51 Comparing candidate commit ec144ce in PR branch Found 2 performance improvements and 1 performance regressions! Performance is the same for 28 metrics, 2 unstable metrics. scenario:line instrumentation - targeted
scenario:method instrumentation
scenario:profiler - sample timeline=false
|
marcotc
approved these changes
Dec 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR introduces a single shared example to replace approximately ONE BILLION copy pasted test cases to test a binary setting that can be read from an env variable.
Motivation:
I've gotten tired of copy-pasting this again and again and decided to finally clean this up.
Change log entry
None.
Additional Notes:
My only regret is not having cleaned this up earlier.
How to test the change?
Validate tests still pass.