[PROF-11035] Require datadog-ruby_core_source >= 3.3.7 to ensure Ruby 3.4 support #4228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… 3.4 support **What does this PR do?** This PR adds an extra version restriction to our `datadog-ruby_core_source` dependency to ensure that version 3.3.7 or newer gets used. **Motivation:** Version 3.3.7 ships support for Ruby 3.4 (using 3.4.0-rc1 headers) and has a nice on-disk footprint reduction so we want to make sure that it gets used, instead of an older version. **Additional Notes:** N/A **How to test the change?** If CI is still green, we're almost good. The final part is testing this with 3.4.0-rc1 -- which we don't yet have in CI. For now I did that locally and got a green build; once we pick up 3.4.0-rc1 (or 3.4.0 stable) in CI, we'll be able to validate this part in CI as well.
|
Thank you for updating Change log entry section 👏 Visited at: 2024-12-16 17:33:28 UTC |
ivoanjo
changed the title
sarahchen6
approved these changes
Dec 16, 2024
BenchmarksBenchmark execution time: 2024-12-16 17:55:49 Comparing candidate commit 6606145 in PR branch Found 1 performance improvements and 2 performance regressions! Performance is the same for 28 metrics, 2 unstable metrics. scenario:line instrumentation - targeted
scenario:method instrumentation
scenario:profiler - sample timeline=false
|
|
Going to merge this one! The "Datadog Software Composition Analysis / Datadog SBOM Generation and Upload (push)" issue is unrelated and is being tracked separately. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR adds an extra version restriction to our
datadog-ruby_core_sourcedependency to ensure that version 3.3.7 or newer gets used.Motivation:
Version 3.3.7 ships support for Ruby 3.4 (using 3.4.0-rc1 headers) and has a nice on-disk footprint reduction so we want to make sure that it gets used, instead of an older version.
Change log entry
Yes. Require datadog-ruby_core_source >= 3.3.7 to ensure Ruby 3.4 support
Additional Notes:
N/A
How to test the change?
If CI is still green, we're almost good. The final part is testing this with 3.4.0-rc1 -- which we don't yet have in CI.
For now I did that locally and got a green build; once we pick up 3.4.0-rc1 (or 3.4.0 stable) in CI, we'll be able to validate this part in CI as well.