Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[🤖] Update Supported Versions #4236

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

TonyCTHsu
Copy link
Contributor

@TonyCTHsu TonyCTHsu commented Dec 18, 2024

This is a PR to update the table for supported integration versions.
Workflow run: Generate Supported Versions
This should be tied to tracer releases, or triggered manually.

@TonyCTHsu TonyCTHsu requested a review from a team as a code owner December 18, 2024 22:23
@TonyCTHsu TonyCTHsu added dev/internal Other internal work that does not need to be included in the changelog integrations Involves tracing integrations labels Dec 18, 2024
Copy link

github-actions bot commented Dec 18, 2024

👋 Hey @DataDog/ruby-guild, please fill "Change log entry" section in the pull request description.

If changes need to be present in CHANGELOG.md you can state it this way

**Change log entry**

Yes. A brief summary to be placed into the CHANGELOG.md

(possible answers Yes/Yep/Yeah)

Or you can opt out like that

**Change log entry**

None.

(possible answers No/Nope/None)

Visited at: 2024-12-19 19:58:39 UTC

@datadog-datadog-prod-us1
Copy link
Contributor

datadog-datadog-prod-us1 bot commented Dec 18, 2024

Datadog Report

Branch report: auto-generate/update-supported-versions
Commit report: 9ad6d48
Test service: dd-trace-rb

❌ 1 Failed (0 Known Flaky), 21970 Passed, 1475 Skipped, 5m 24.81s Total Time

❌ Failed Tests (1)

  • gem release process datadog.gemspec files includes all important files - rspec - Details

    Expand for error
     the missing elements were:      ["gem_output.json", "integration_versions.md"]
     
     Failure/Error:
       expect(gemspec.files)
         .to match_array(
           \`git ls-files -z\`
             .split("\x0")
             .reject { |f| f.match(directories_excluded) }
             .reject { |f| f.match(single_files_excluded) }
         )
     ...
    

@pr-commenter
Copy link

pr-commenter bot commented Dec 18, 2024

Benchmarks

Benchmark execution time: 2024-12-24 15:06:25

Comparing candidate commit 9ad6d48 in PR branch auto-generate/update-supported-versions with baseline commit 44f36d3 in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 31 metrics, 2 unstable metrics.

@quinna-h quinna-h marked this pull request as draft December 18, 2024 23:17
@TonyCTHsu TonyCTHsu force-pushed the auto-generate/update-supported-versions branch from 486ab51 to 392a80f Compare December 19, 2024 19:58
@TonyCTHsu TonyCTHsu force-pushed the auto-generate/update-supported-versions branch from 392a80f to 68287a9 Compare December 20, 2024 15:54
| graphql | 1.13.21 | 2.3.7 | 1.13.21 | 2.3.6 |
| grpc | 1.48.0 | 1.67.0 | None | None |
| hanami | 1.3.5 | 1.3.5 | None | None |
| http | 5.0.1 | 5.2.0 | 4.4.1 | 4.4.1 |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

| hanami | 1.3.5 | 1.3.5 | None | None |
| http | 5.0.1 | 5.2.0 | 4.4.1 | 4.4.1 |
| httpclient | 2.8.3 | 2.8.3 | 2.8.3 | 2.8.3 |
| httprb | 5.0.1 | 5.2.0 | 4.4.1 | 4.4.1 |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing httpx

| httpclient | 2.8.3 | 2.8.3 | 2.8.3 | 2.8.3 |
| httprb | 5.0.1 | 5.2.0 | 4.4.1 | 4.4.1 |
| kafka | 1.5.0 | 1.5.0 | 1.5.0 | 1.5.0 |
| lograge | 0.12.0 | 0.14.0 | 0.12.0 | 0.14.0 |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing makara because it is not its own integration, but part of active_record
maybe in the contrib/active_record/integration.rb need to include self.gems

@TonyCTHsu TonyCTHsu force-pushed the auto-generate/update-supported-versions branch from 68287a9 to 9ad6d48 Compare December 24, 2024 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev/internal Other internal work that does not need to be included in the changelog integrations Involves tracing integrations
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants