Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix case & grammar in issue template #4244

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix case & grammar in issue template #4244

wants to merge 1 commit into from

Conversation

p-datadog
Copy link
Member

@p-datadog p-datadog commented Dec 25, 2024 •
edited
Loading

What does this PR do?

Repairs the case and grammar in the "how does datadog help you" question in the issue template

Motivation:

Change log entry
None

Additional Notes:

Follow-up to #4235

How to test the change?

N/A

cc @tlhunter

@p-datadog p-datadog requested a review from a team as a code owner December 25, 2024 16:59
@p-datadog p-datadog requested a review from tlhunter December 25, 2024 16:59
@p-datadog p-datadog added the dev/internal Other internal work that does not need to be included in the changelog label Dec 25, 2024
@github-actions github-actions bot added the dev/github Github repository maintenance and automation label Dec 25, 2024
@datadog-datadog-prod-us1
Copy link
Contributor

datadog-datadog-prod-us1 bot commented Dec 25, 2024 •
edited
Loading

Datadog Report

Branch report: issue-template-case
Commit report: 94a9147
Test service: dd-trace-rb

❌ 15 Failed (0 Known Flaky), 20874 Passed, 1327 Skipped, 4m 17.79s Total Time
❄️ 49 New Flaky

❌ Failed Tests (15)

This report shows up to 5 failed tests.

  • Rails cache #delete - rspec - Details

    Expand for error 
     undefined method 'embed_authenticity_token_in_remote_forms=' for module ActionView::Helpers::FormTagHelper
 
 Failure/Error: initialize!
 
 NoMethodError:
   undefined method 'embed_authenticity_token_in_remote_forms=' for module ActionView::Helpers::FormTagHelper
 /usr/local/bundle/gems/actionview-6.1.7.10/lib/action_view/railtie.rb:17:in 'block in <class:Railtie>'
 /usr/local/bundle/gems/activesupport-6.1.7.10/lib/active_support/lazy_load_hooks.rb:68:in 'block in ActiveSupport::LazyLoadHooks#execute_hook'
 /usr/local/bundle/gems/activesupport-6.1.7.10/lib/active_support/lazy_load_hooks.rb:61:in 'ActiveSupport::LazyLoadHooks#with_execution_control'
 /usr/local/bundle/gems/activesupport-6.1.7.10/lib/active_support/lazy_load_hooks.rb:66:in 'ActiveSupport::LazyLoadHooks#execute_hook'
 ...

  • Rails cache #delete when cache_key.enabled is false - rspec - Details

    Expand for error 
     undefined method 'embed_authenticity_token_in_remote_forms=' for module ActionView::Helpers::FormTagHelper
 
 Failure/Error: initialize!
 
 NoMethodError:
   undefined method 'embed_authenticity_token_in_remote_forms=' for module ActionView::Helpers::FormTagHelper
 /usr/local/bundle/gems/actionview-6.1.7.10/lib/action_view/railtie.rb:17:in 'block in <class:Railtie>'
 /usr/local/bundle/gems/activesupport-6.1.7.10/lib/active_support/lazy_load_hooks.rb:68:in 'block in ActiveSupport::LazyLoadHooks#execute_hook'
 /usr/local/bundle/gems/activesupport-6.1.7.10/lib/active_support/lazy_load_hooks.rb:61:in 'ActiveSupport::LazyLoadHooks#with_execution_control'
 /usr/local/bundle/gems/activesupport-6.1.7.10/lib/active_support/lazy_load_hooks.rb:66:in 'ActiveSupport::LazyLoadHooks#execute_hook'
 ...

  • Rails cache #fetch_multi when the method is defined with exception - rspec - Details

    Expand for error 
     undefined method 'embed_authenticity_token_in_remote_forms=' for module ActionView::Helpers::FormTagHelper
 
 Failure/Error: initialize!
 
 NoMethodError:
   undefined method 'embed_authenticity_token_in_remote_forms=' for module ActionView::Helpers::FormTagHelper
 /usr/local/bundle/gems/actionview-6.1.7.10/lib/action_view/railtie.rb:17:in 'block in <class:Railtie>'
 /usr/local/bundle/gems/activesupport-6.1.7.10/lib/active_support/lazy_load_hooks.rb:68:in 'block in ActiveSupport::LazyLoadHooks#execute_hook'
 /usr/local/bundle/gems/activesupport-6.1.7.10/lib/active_support/lazy_load_hooks.rb:61:in 'ActiveSupport::LazyLoadHooks#with_execution_control'
 /usr/local/bundle/gems/activesupport-6.1.7.10/lib/active_support/lazy_load_hooks.rb:66:in 'ActiveSupport::LazyLoadHooks#execute_hook'
 ...

  • Rails cache #fetch_multi when the method is defined with exception and when cache_key.enabled is false - rspec - Details

    Expand for error 
     undefined method 'embed_authenticity_token_in_remote_forms=' for module ActionView::Helpers::FormTagHelper
 
 Failure/Error: initialize!
 
 NoMethodError:
   undefined method 'embed_authenticity_token_in_remote_forms=' for module ActionView::Helpers::FormTagHelper
 /usr/local/bundle/gems/actionview-6.1.7.10/lib/action_view/railtie.rb:17:in 'block in <class:Railtie>'
 /usr/local/bundle/gems/activesupport-6.1.7.10/lib/active_support/lazy_load_hooks.rb:68:in 'block in ActiveSupport::LazyLoadHooks#execute_hook'
 /usr/local/bundle/gems/activesupport-6.1.7.10/lib/active_support/lazy_load_hooks.rb:61:in 'ActiveSupport::LazyLoadHooks#with_execution_control'
 /usr/local/bundle/gems/activesupport-6.1.7.10/lib/active_support/lazy_load_hooks.rb:66:in 'ActiveSupport::LazyLoadHooks#execute_hook'
 ...

  • Rails cache #fetch_multi when the method is not defined - rspec - Details

    Expand for error 
     undefined method 'embed_authenticity_token_in_remote_forms=' for module ActionView::Helpers::FormTagHelper
 
 Failure/Error: initialize!
 
 NoMethodError:
   undefined method 'embed_authenticity_token_in_remote_forms=' for module ActionView::Helpers::FormTagHelper
 /usr/local/bundle/gems/actionview-6.1.7.10/lib/action_view/railtie.rb:17:in 'block in <class:Railtie>'
 /usr/local/bundle/gems/activesupport-6.1.7.10/lib/active_support/lazy_load_hooks.rb:68:in 'block in ActiveSupport::LazyLoadHooks#execute_hook'
 /usr/local/bundle/gems/activesupport-6.1.7.10/lib/active_support/lazy_load_hooks.rb:61:in 'ActiveSupport::LazyLoadHooks#with_execution_control'
 /usr/local/bundle/gems/activesupport-6.1.7.10/lib/active_support/lazy_load_hooks.rb:66:in 'ActiveSupport::LazyLoadHooks#execute_hook'
 ...

New Flaky Tests (49)

  • Rails cache #delete behaves like an instrumented cache method behaves like measured span for integration does not set _dd.measured on the span - rspec - Last Failure

    Expand for error 
     undefined method 'embed_authenticity_token_in_remote_forms=' for module ActionView::Helpers::FormTagHelper
 
 Failure/Error: initialize!
 
 NoMethodError:
   undefined method 'embed_authenticity_token_in_remote_forms=' for module ActionView::Helpers::FormTagHelper
 Shared Example Group: "measured span for integration" called from ./spec/datadog/tracing/contrib/rails/cache_spec.rb:84
 Shared Example Group: "an instrumented cache method" called from ./spec/datadog/tracing/contrib/rails/cache_spec.rb:329
 /usr/local/bundle/gems/actionview-6.1.7.10/lib/action_view/railtie.rb:17:in 'block in <class:Railtie>'
 /usr/local/bundle/gems/activesupport-6.1.7.10/lib/active_support/lazy_load_hooks.rb:68:in 'block in ActiveSupport::LazyLoadHooks#execute_hook'
 ...

  • Rails cache #delete behaves like an instrumented cache method disabled at integration level does not instrument - rspec - Last Failure

    Expand for error 
     undefined method 'embed_authenticity_token_in_remote_forms=' for module ActionView::Helpers::FormTagHelper
 
 Failure/Error: initialize!
 
 NoMethodError:
   undefined method 'embed_authenticity_token_in_remote_forms=' for module ActionView::Helpers::FormTagHelper
 Shared Example Group: "an instrumented cache method" called from ./spec/datadog/tracing/contrib/rails/cache_spec.rb:329
 /usr/local/bundle/gems/actionview-6.1.7.10/lib/action_view/railtie.rb:17:in 'block in <class:Railtie>'
 /usr/local/bundle/gems/activesupport-6.1.7.10/lib/active_support/lazy_load_hooks.rb:68:in 'block in ActiveSupport::LazyLoadHooks#execute_hook'
 /usr/local/bundle/gems/activesupport-6.1.7.10/lib/active_support/lazy_load_hooks.rb:61:in 'ActiveSupport::LazyLoadHooks#with_execution_control'
 ...

  • Rails cache #delete behaves like an instrumented cache method disabled at tracer level does not instrument - rspec - Last Failure

    Expand for error 
     undefined method 'embed_authenticity_token_in_remote_forms=' for module ActionView::Helpers::FormTagHelper
 
 Failure/Error: initialize!
 
 NoMethodError:
   undefined method 'embed_authenticity_token_in_remote_forms=' for module ActionView::Helpers::FormTagHelper
 Shared Example Group: "an instrumented cache method" called from ./spec/datadog/tracing/contrib/rails/cache_spec.rb:329
 /usr/local/bundle/gems/actionview-6.1.7.10/lib/action_view/railtie.rb:17:in 'block in <class:Railtie>'
 /usr/local/bundle/gems/activesupport-6.1.7.10/lib/active_support/lazy_load_hooks.rb:68:in 'block in ActiveSupport::LazyLoadHooks#execute_hook'
 /usr/local/bundle/gems/activesupport-6.1.7.10/lib/active_support/lazy_load_hooks.rb:61:in 'ActiveSupport::LazyLoadHooks#with_execution_control'
 ...

  • Rails cache #delete behaves like an instrumented cache method with a cache different from Rails' default store returns the matching backend type - rspec - Last Failure

    Expand for error 
     undefined method 'embed_authenticity_token_in_remote_forms=' for module ActionView::Helpers::FormTagHelper
 
 Failure/Error: initialize!
 
 NoMethodError:
   undefined method 'embed_authenticity_token_in_remote_forms=' for module ActionView::Helpers::FormTagHelper
 Shared Example Group: "an instrumented cache method" called from ./spec/datadog/tracing/contrib/rails/cache_spec.rb:329
 /usr/local/bundle/gems/actionview-6.1.7.10/lib/action_view/railtie.rb:17:in 'block in <class:Railtie>'
 /usr/local/bundle/gems/activesupport-6.1.7.10/lib/active_support/lazy_load_hooks.rb:68:in 'block in ActiveSupport::LazyLoadHooks#execute_hook'
 /usr/local/bundle/gems/activesupport-6.1.7.10/lib/active_support/lazy_load_hooks.rb:61:in 'ActiveSupport::LazyLoadHooks#with_execution_control'
 ...

  • Rails cache #delete behaves like an instrumented cache method with a cache not in the ActiveSupport::Cache:: namespace returns the matching backend type - rspec - Last Failure

    Expand for error 
     undefined method 'embed_authenticity_token_in_remote_forms=' for module ActionView::Helpers::FormTagHelper
 
 Failure/Error: initialize!
 
 NoMethodError:
   undefined method 'embed_authenticity_token_in_remote_forms=' for module ActionView::Helpers::FormTagHelper
 Shared Example Group: "an instrumented cache method" called from ./spec/datadog/tracing/contrib/rails/cache_spec.rb:329
 /usr/local/bundle/gems/actionview-6.1.7.10/lib/action_view/railtie.rb:17:in 'block in <class:Railtie>'
 /usr/local/bundle/gems/activesupport-6.1.7.10/lib/active_support/lazy_load_hooks.rb:68:in 'block in ActiveSupport::LazyLoadHooks#execute_hook'
 /usr/local/bundle/gems/activesupport-6.1.7.10/lib/active_support/lazy_load_hooks.rb:61:in 'ActiveSupport::LazyLoadHooks#with_execution_control'
 ...

@pr-commenter
Copy link

pr-commenter bot commented Dec 25, 2024

Benchmarks

Benchmark execution time: 2024-12-25 17:22:21

Comparing candidate commit 94a9147 in PR branch issue-template-case with baseline commit 44f36d3 in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 31 metrics, 2 unstable metrics.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tlhunter tlhunter Awaiting requested review from tlhunter

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
dev/github Github repository maintenance and automation dev/internal Other internal work that does not need to be included in the changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@p-datadog @p