Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove obsolete code from gateway watchers #4270

Merged
merged 1 commit into from
Jan 10, 2025

Conversation

y9v
Copy link
Member

@y9v y9v commented Jan 9, 2025

This :monitor event that we are adding to the response in every gateway
watcher is not used anywhere. We are only looking for :block events in
the method callers and ignoring the rest.
@y9v y9v self-assigned this Jan 9, 2025
@y9v y9v requested a review from a team as a code owner January 9, 2025 16:09
@github-actions github-actions bot added integrations Involves tracing integrations appsec Application Security monitoring product labels Jan 9, 2025
@datadog-datadog-prod-us1
Copy link
Contributor

Datadog Report

Branch report: appsec-remove-obsolete-code-from-gateway-watchers
Commit report: 85f6572
Test service: dd-trace-rb

✅ 0 Failed, 22135 Passed, 1476 Skipped, 5m 22.41s Total Time

@pr-commenter
Copy link

pr-commenter bot commented Jan 9, 2025

Benchmarks

Benchmark execution time: 2025-01-09 16:28:30

Comparing candidate commit 85f6572 in PR branch appsec-remove-obsolete-code-from-gateway-watchers with baseline commit bb43112 in branch master.

Found 0 performance improvements and 2 performance regressions! Performance is the same for 29 metrics, 2 unstable metrics.

scenario:profiler - Allocations ()

  • 🟥 throughput [-200528.064op/s; -188296.198op/s] or [-5.996%; -5.630%]

scenario:tracing - Propagation - Trace Context

  • 🟥 throughput [-3872.210op/s; -3775.047op/s] or [-10.161%; -9.906%]

@y9v y9v merged commit 7f8e8fd into master Jan 10, 2025
347 checks passed
@y9v y9v deleted the appsec-remove-obsolete-code-from-gateway-watchers branch January 10, 2025 14:20
@github-actions github-actions bot added this to the 2.9.0 milestone Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
appsec Application Security monitoring product integrations Involves tracing integrations
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants