Conversation
Before we were not setting `apply_state` to ACKNOWLEDGED on remote config content.
Datadog ReportBranch report: ✅ 0 Failed, 22079 Passed, 1476 Skipped, 5m 22.35s Total Time |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4345 +/- ##
=======================================
Coverage 97.72% 97.73%
=======================================
Files 1368 1368
Lines 82998 83014 +16
Branches 4220 4221 +1
=======================================
+ Hits 81113 81133 +20
+ Misses 1885 1881 -4 ☔ View full report in Codecov by Sentry. |
BenchmarksBenchmark execution time: 2025-02-05 14:38:12 Comparing candidate commit d9bcea9 in PR branch Found 1 performance improvements and 0 performance regressions! Performance is the same for 30 metrics, 2 unstable metrics. scenario:line instrumentation - targeted
|
Strech
left a comment
Strech
left a comment
There was a problem hiding this comment.
I have doubts about marking content as applied without actual use of it before hand.
| SYSTEM_TESTS_REF: 239c3eba6de0473817d3d88ebbc025c9d0c9574b | ||
| # SYSTEM_TESTS_REF: main # This must always be set to `main` on dd-trace-rb's master branch | ||
| # TODO: remove this change before merging to master | ||
| SYSTEM_TESTS_REF: enable-ip-blocking-for-ruby |
There was a problem hiding this comment.
Was this supposed to be removed before merge?
4 participants
Before we were not setting
apply_stateto ACKNOWLEDGED on remote config content, which caused some system tests to fail.What does this PR do?
This PR adds setting of
apply_stateon remote config content toACKNOWLEDGEDafter successful processing.Motivation:
Failing system tests for full denylist blocking: DataDog/system-tests#3937
Change log entry
None, this is internal change. Changes via remote config were applied before too, it's just the status that wasn't set correctly.
Additional Notes:
None.
How to test the change?
CI should be enough.