Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OpenTracing] Fix distributed tracing signed int ids #539

Merged
merged 1 commit into from
Sep 14, 2018

Conversation

delner
Copy link
Contributor

@delner delner commented Sep 13, 2018

Analogous to #530 , OpenTracing was discarding signed integers displayed as negative integers received via distributed tracing from other tracers. This pull request applies the same kind of conversion of signed to unsigned int, to provide compatibility.

@delner delner added bug Involves a bug core Involves Datadog core libraries labels Sep 13, 2018
@delner delner added this to the 0.16.0 milestone Sep 13, 2018
@delner delner self-assigned this Sep 13, 2018
@delner delner requested a review from pawelchcki September 13, 2018 17:31
Copy link
Contributor

@pawelchcki pawelchcki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@delner delner merged commit 76a1493 into feature/opentracing Sep 14, 2018
@delner delner deleted the fix/opentracing_signed_int_ids branch September 14, 2018 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Involves a bug core Involves Datadog core libraries
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants