Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement Sidekiq integration configuration #545

Merged
merged 1 commit into from
Sep 20, 2018
Merged

Implement Sidekiq integration configuration #545

merged 1 commit into from
Sep 20, 2018

Conversation

delner
Copy link
Contributor

@delner delner commented Sep 17, 2018 •
edited
Loading

This pull request implements the configuration core from #450 in the Resque integration.

@delner delner added integrations Involves tracing integrations dev/refactor Involves refactoring existing components labels Sep 17, 2018
@delner delner self-assigned this Sep 17, 2018
@delner delner requested a review from pawelchcki September 17, 2018 18:07
@delner delner force-pushed the refactor/sidekiq_integration_configuration branch 2 times, most recently from 815ad3a to c5c0929 Compare September 17, 2018 18:41
@delner delner force-pushed the refactor/sidekiq_integration_configuration branch from c5c0929 to 228f03e Compare September 17, 2018 18:42
pawelchcki
pawelchcki approved these changes Sep 18, 2018
View reviewed changes
Copy link
Contributor

@pawelchcki pawelchcki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@delner delner merged commit 7b4536f into refactor/upgrade_to_integration_configuration Sep 20, 2018
@delner delner deleted the refactor/sidekiq_integration_configuration branch September 20, 2018 16:53
@delner delner mentioned this pull request Sep 20, 2018
Merged
26 tasks
delner added a commit that referenced this pull request Sep 21, 2018
@delner
Refactored: Sidekiq to use Datadog::Contrib::Integration. (#545)
54203f3
delner added a commit that referenced this pull request Sep 21, 2018
@delner
Refactored: Sidekiq to use Datadog::Contrib::Integration. (#545)
11bce27
delner added a commit that referenced this pull request Sep 21, 2018
@delner
Refactored: Sidekiq to use Datadog::Contrib::Integration. (#545)
c14f87d
delner added a commit that referenced this pull request Sep 21, 2018
@delner
Refactored: Sidekiq to use Datadog::Contrib::Integration. (#545)
677476b
delner added a commit that referenced this pull request Sep 21, 2018
@delner
Refactored: Sidekiq to use Datadog::Contrib::Integration. (#545)
1f06610
delner added a commit that referenced this pull request Sep 21, 2018
@delner
Refactored: Sidekiq to use Datadog::Contrib::Integration. (#545)
d15aa9e
delner added a commit that referenced this pull request Sep 24, 2018
@delner
Refactored: Sidekiq to use Datadog::Contrib::Integration. (#545)
8074a42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pawelchcki pawelchcki pawelchcki approved these changes

Assignees

@delner delner

Labels
dev/refactor Involves refactoring existing components integrations Involves tracing integrations
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@delner @pawelchcki