Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Redis integration configuration #555

Conversation

delner
Copy link
Contributor

@delner delner commented Sep 21, 2018

This pull request implements the configuration core from #450 in the Redis integration.

@delner delner added integrations Involves tracing integrations dev/refactor Involves refactoring existing components labels Sep 21, 2018
@delner delner self-assigned this Sep 21, 2018
@delner delner requested a review from pawelchcki September 21, 2018 17:20
@delner delner force-pushed the refactor/redis_integration_configuration branch from 33fe0c0 to 6a3933e Compare September 21, 2018 17:24
@delner delner force-pushed the refactor/redis_integration_configuration branch from 6a3933e to f7e3395 Compare September 21, 2018 18:41
@delner delner force-pushed the refactor/upgrade_to_integration_configuration branch 5 times, most recently from e7f8cca to e772421 Compare September 21, 2018 21:11
@delner delner force-pushed the refactor/redis_integration_configuration branch 2 times, most recently from f0fbb53 to ef80c47 Compare September 24, 2018 15:33
@delner delner force-pushed the refactor/upgrade_to_integration_configuration branch from e772421 to 16d9782 Compare September 24, 2018 15:46
@delner delner force-pushed the refactor/redis_integration_configuration branch from ef80c47 to 48b500e Compare September 24, 2018 15:51
Copy link
Contributor

@pawelchcki pawelchcki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

app: Ext::APP,
app_type: Datadog::Ext::AppTypes::DB,
tracer: tracer
)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@delner delner force-pushed the refactor/redis_integration_configuration branch from 48b500e to b4f1e15 Compare September 26, 2018 20:12
@delner delner merged commit 65c91f2 into refactor/upgrade_to_integration_configuration Sep 26, 2018
@delner delner deleted the refactor/redis_integration_configuration branch September 26, 2018 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev/refactor Involves refactoring existing components integrations Involves tracing integrations
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants