Implement HTTP integration configuration #556
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
delner
added
integrations
26 tasks
delner
force-pushed
the
refactor/http_integration_configuration
branch
2 times, most recently
from
d13ad68 to
aaafcbc
Compare
delner
force-pushed
the
refactor/upgrade_to_integration_configuration
branch
5 times, most recently
from
e7f8cca to
e772421
Compare
delner
force-pushed
the
refactor/http_integration_configuration
branch
2 times, most recently
from
c3ab74c to
7f83af7
Compare
delner
force-pushed
the
refactor/upgrade_to_integration_configuration
branch
from
e772421 to
16d9782
Compare
delner
force-pushed
the
refactor/http_integration_configuration
branch
from
7f83af7 to
ee0b2c9
Compare
pawelchcki
approved these changes
Sep 26, 2018
| module HTTP | ||
| # HTTP integration circuit breaker behavior | ||
| # For avoiding recursive traces. | ||
| module CircuitBreaker |
There was a problem hiding this comment.
Might be a bit confusing with CircuitBreaker pattern. But I don't have better suggestion :D
There was a problem hiding this comment.
Is there a "circuit breaker" pattern? I was trying to think of something that encapsulated the idea of "if looping, escape", like a short-circuit where the circuit breaker trips to prevent an overload. But maybe a metaphor here isn't the best choice of naming scheme.
There was a problem hiding this comment.
FYI https://martinfowler.com/bliki/CircuitBreaker.html
on a high level it also breaks circuit, but its a bit more dynamic and serves a bit different purpose.
There was a problem hiding this comment.
Right... a microservices related pattern. Forgot about this one.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request implements the configuration core from #450 in the HTTP integration.