Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement MongoDB integration configuration #558

Conversation

delner
Copy link
Contributor

@delner delner commented Sep 24, 2018

This pull request implements the configuration core from #450 in the MongoDB integration.

@delner delner added integrations Involves tracing integrations dev/refactor Involves refactoring existing components labels Sep 24, 2018
@delner delner self-assigned this Sep 24, 2018
@delner delner requested a review from pawelchcki September 24, 2018 18:33
Copy link
Contributor

@pawelchcki pawelchcki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the Constants cleanup!
LGTM

span.set_tag(Datadog::Ext::Mongo::COLLECTION, query['collection'])
span.set_tag(Datadog::Ext::Mongo::OPERATION, query['operation'])
span.set_tag(Datadog::Ext::Mongo::QUERY, serialized_query)
span.set_tag(Ext::TAG_DB, query['database'])
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@delner delner force-pushed the refactor/mongo_integration_configuration branch from 0890544 to b3d7817 Compare September 26, 2018 20:14
@delner delner merged commit cc9d368 into refactor/upgrade_to_integration_configuration Sep 26, 2018
@delner delner deleted the refactor/mongo_integration_configuration branch September 26, 2018 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev/refactor Involves refactoring existing components integrations Involves tracing integrations
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants