Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Elasticsearch integration configuration #561

Conversation

delner
Copy link
Contributor

@delner delner commented Sep 24, 2018

This pull request implements the configuration core from #450 in the Elasticsearch integration.

@delner delner added integrations Involves tracing integrations dev/refactor Involves refactoring existing components labels Sep 24, 2018
@delner delner self-assigned this Sep 24, 2018
@delner delner requested a review from pawelchcki September 24, 2018 22:14
@@ -74,29 +67,29 @@ def perform_request(*args)

url = full_url.path
response = nil
pin.tracer.trace('elasticsearch.query') do |span|
pin.tracer.trace(Datadog::Contrib::Elasticsearch::Ext::SPAN_QUERY) do |span|
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@delner delner merged commit c754c2c into refactor/upgrade_to_integration_configuration Sep 26, 2018
@delner delner deleted the refactor/elasticsearch_integration_configuration branch September 26, 2018 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev/refactor Involves refactoring existing components integrations Involves tracing integrations
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants