Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[rails] active_record keeps track of the :cached key if it's available #57

Merged
merged 1 commit into from
Mar 22, 2017

Conversation

palazzem
Copy link
Contributor

What it does

Keeps track of the :cached attribute in the active_record instrumentation payload. This is a best effort support for the moment, since this change has been deployed in the Rails master but it has not been released.

Having rails.db.cached meta is useful to explain users why some SQL queries has 0ns of duration.

@palazzem palazzem added enhancement integrations Involves tracing integrations labels Jan 13, 2017
@palazzem palazzem requested a review from ufoot January 13, 2017 21:48
@palazzem palazzem force-pushed the palazzem/rails-orm-cache branch from a961f8f to ffc1142 Compare January 24, 2017 15:52
@palazzem palazzem modified the milestone: 0.6.0 Mar 6, 2017
@ufoot ufoot added this to the 0.6.0 milestone Mar 21, 2017
@ufoot ufoot merged commit ffc1142 into master Mar 22, 2017
@palazzem palazzem deleted the palazzem/rails-orm-cache branch April 21, 2017 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrations Involves tracing integrations
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants