[rails] adding cache support for Passenger #64
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e instrumentation
palazzem
force-pushed
the
palazzem/passenger-support
branch
from
0a45ab4 to
c6126fa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
Adds cache support to Passenger. Because of an implementation detail related to how Rails 3.x stores the cache instrumentation, Passenger didn't work properly. Spans were correctly created using the
start_cache_*.active_supportsignals, but they were never closed becausecache_*.active_supportwere not activated.This patch ensures that cache instrumentation is activated if the
auto_instrumentflag is on.