Support Shoryuken in batch mode #655
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shoryuken can be run in a batch mode, in which case `sqs_msg` and `body` will be arrays. Shoryuken [monkey patches](https://github.com/phstc/shoryuken/blob/bc7938942270a1171d1597064698d88c3f36a4ec/lib/shoryuken/manager.rb#L93) in a `message_id` method, but `attributes` won't exist on an array.
|
Ahh okay, so under the current implementation this would be considered a bug? If so, this seems like a pretty sensible change. Just wish there was a way of replicating batch mode in our tests, so we could ensure it doesn't break. |
delner
added
integrations
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Shoryuken can be run in a batch mode, in which case
sqs_msgandbodywill be arrays.Shoryuken monkey patches in a
message_idmethod, butattributeswon't exist on an array.