Fix ActiveRecord :connection incompatibility with serialization libraries #662
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
delner
added
bug
delner
force-pushed
the
fix/active_record_event_connection_serialization
branch
from
95311ef to
601fd80
Compare
brettlangdon
approved these changes
Dec 20, 2018
|
Sad to see that your previous solution didn't work. It was a better solution. Thanks for your work :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of
0.18.0via #649, we injected the ActiveRecord adapter object as:connectioninto thesql.active_record, mimicking the behavior of rails/rails#34602 which appears in Rails 6. We did this in order to workaround a performance problem for JRuby, where our previous implementation ofid2refwas causing issues.There are other 3rd party libraries that serialize the output of this
sql.active_recordevent (e.g.meta_requestgem), and the:connectionobject we injected is not serializable, causing aSystemStackErrorerror. It's unclear whether this is a breaking change for Rails 6, such that these libraries should upgrade to be compatible with Rails 6, or just a bug.Either way, we can't mimic this behavior here for users with Rails < version 6, so we need to implement a new strategy. This pull request instead resolves connections by searching connection pools and finding connection configuration that way, as was originally implemented by @guizmaii.
Addresses #661.