Shoryuken: use job name as resource instead of the wrapper

[aurelian]

Currently all jobs are grouped within the same job wrapper, ActiveJob::QueueAdapters::ShoryukenAdapter::JobWrapper

With this proposal, the resource changes from:

to

[delner]

Ahh, yeah, this is an ActiveJob compatibility thing... we've seen this before, I think for Sidekiq. I'll take a deeper look at this a bit later, but it looks like this is a desirable change.

[delner]

I think how it was written, body['job_class'] could raise an exception if the body was not a Hash or String. It not raising an error with String was complete coincidence too because it defines []; mostly a happy accident that this wasn't more problematic.

Modified the logic a bit for type checking and safety, and added some tests that actually assert whether this is a safe change: Shoryuken unit tests don't run properly in our test suite because it currently doesn't run middleware with the InlineExecutor. Hence we could be introducing bugs without knowing it. The tests I added should help guard against this, even if they're a bit brittle and not ideal.

[delner]

👍

[aurelian]

Thanks! Great job adding those tests!