Fix priority sampling dropping traces #686
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pawelchcki
previously approved these changes
Feb 7, 2019
There was a problem hiding this comment.
Looks good! Thanks for digging into it!
I've left a few optional comments to suggest moving away from word sampling in this context as we're actually assigning a priority and no sampling will ever be done.
But it might be just me holding a grudge against word sampling here, and would like to find a way to ensure no one will be misled by it (like I was :) ).
LotharSee
reviewed
Feb 7, 2019
LotharSee
reviewed
Feb 7, 2019
LotharSee
reviewed
Feb 7, 2019
LotharSee
reviewed
Feb 7, 2019
brettlangdon
reviewed
Feb 7, 2019
There was a problem hiding this comment.
really minor comments, otherwise I think this looks good.
input again from @LotharSee would be great, and I want to step through it again in a bit
brettlangdon
approved these changes
Feb 7, 2019
LotharSee
approved these changes
Feb 7, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
Datadog::PrioritySamplerwas incorrectly applying an internal sampler to some traces, and would mark them as rejected, thus preventing them from reaching the agent.This pull request removes this sampling behavior, and instead marks all spans as "sampled" when priority sampling is enabled, which allows all spans and traces to reach the agent.