[contrib:rails] reporting controller exceptions as errors in stats #95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ufoot
force-pushed
the
christian/rails500error
branch
from
7e39b72 to
367832c
Compare
talwai
reviewed
Mar 23, 2017
| span.set_tag(Datadog::Ext::HTTP::STATUS_CODE, payload.fetch(:status, '?').to_s) | ||
| status = payload.fetch(:status, '?').to_s | ||
| span.status = 1 if status.starts_with?('50') | ||
| span.set_tag(Datadog::Ext::HTTP::STATUS_CODE, status) |
There was a problem hiding this comment.
is it possible for us to include a stacktrace in either of these clauses? This is consistent with what we do in span.set_error https://github.com/DataDog/dd-trace-rb/blob/master/lib/ddtrace/span.rb#L89
There was a problem hiding this comment.
Agree, that was missing. Using set_error should be enough.
palazzem
reviewed
Mar 24, 2017
| @@ -51,15 +51,17 @@ def self.process_action(_name, start, finish, _id, payload) | |||
| if payload[:exception].nil? | |||
| # [christian] in some cases :status is not defined, | |||
| # rather than firing an error, simply acknowledge we don't know it. | |||
| span.set_tag(Datadog::Ext::HTTP::STATUS_CODE, payload.fetch(:status, '?').to_s) | |||
| status = payload.fetch(:status, '?').to_s | |||
| span.status = 1 if status.starts_with?('50') | |||
There was a problem hiding this comment.
we can have more 5xx errors:
511 Network Authentication Required
520 Web server is returning an unknown error
522 Connection timed out
524 A timeout occurred
I think you can:
status = payload.fetch(:status, '?') # assuming status is integer
span.status = 1 if status.between?(500,599)
span.set_tag(Datadog::Ext::HTTP::STATUS_CODE, status.to_s)| span.set_tag(Datadog::Ext::HTTP::STATUS_CODE, payload.fetch(:status, '?').to_s) | ||
| status = payload.fetch(:status, '?').to_s | ||
| span.status = 1 if status.starts_with?('50') | ||
| span.set_tag(Datadog::Ext::HTTP::STATUS_CODE, status) |
There was a problem hiding this comment.
Agree, that was missing. Using set_error should be enough.
ufoot
force-pushed
the
christian/rails500error
branch
from
afa385a to
2aadfa5
Compare
ufoot
force-pushed
the
christian/rails500error
branch
from
2aadfa5 to
60726ce
Compare
palazzem
approved these changes
Mar 24, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.