feat(propagation): multi-value header extraction support #33
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iunanua
changed the title
iunanua
force-pushed
the
igor/multi-value-headers
branch
from
bf4a23f to
bed756a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Update opentelemetry version and implement the
Extractor::get_allto support multi-value header extraction.Also two new methods implemented:
get_comma_separated_value_from_extractorto help dealing with theExtractor::get_allresultget_single_value_from_extractorto ensure that a key only has one value and return an error in case of more than one valueMotivation
What inspired you to submit this pull request?
Additional Notes
Modifications in Cargo.toml are temporary until new opentelemetry version is released