chore(bench): datadog vs opentelemetry tracers comparison #43
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iunanua
commented
Jun 30, 2025
datadog-opentelemetry/Cargo.toml
Outdated
|
|
||
| # Depend on ourselves to have APIs exposed only during tests | ||
| datadog-opentelemetry = { path = ".", features = ["test-utils"] } | ||
| # datadog-opentelemetry = { path = ".", features = ["test-utils"] } |
There was a problem hiding this comment.
I had to comment out this dependency to disable test-utils feature for benchmark and the change breaks the tests :S
It should be enabled for test but not for bench...
There was a problem hiding this comment.
Cargo is notoriously broken when it comes to this. I don't know how to structure it properly.
There was a problem hiding this comment.
One way is to move the benchmark to a separate crate.
iunanua
changed the title
iunanua
force-pushed
the
igor/bench
branch
2 times, most recently
from
f6b8e34 to
8361896
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add a new bechmark comparing opentelemetry vs datadog-opentelemetry tracers
Additional Notes
WIP