feat(dd-trace-propagation): export datadog mod
#62
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
duncanista
commented
Aug 22, 2025
Comment on lines
+24
to
+30
| pub const DATADOG_HIGHER_ORDER_TRACE_ID_BITS_KEY: &str = "_dd.p.tid"; | ||
| pub const DATADOG_TRACE_ID_KEY: &str = "x-datadog-trace-id"; | ||
| pub const DATADOG_ORIGIN_KEY: &str = "x-datadog-origin"; | ||
| pub const DATADOG_PARENT_ID_KEY: &str = "x-datadog-parent-id"; | ||
| pub const DATADOG_SAMPLING_PRIORITY_KEY: &str = "x-datadog-sampling-priority"; | ||
| pub const DATADOG_TAGS_KEY: &str = "x-datadog-tags"; | ||
| pub const DATADOG_PROPAGATION_ERROR_KEY: &str = "_dd.propagation_error"; |
There was a problem hiding this comment.
Wondering if it would be better to export some of this as constants so that the import is not dd_trace_propgation::datadog::{...} but just dd_trace_propagation::constants::{...}
There was a problem hiding this comment.
Let's keep them in the datadog namespace.
bantonsson
approved these changes
Aug 27, 2025
Comment on lines
+24
to
+30
| pub const DATADOG_HIGHER_ORDER_TRACE_ID_BITS_KEY: &str = "_dd.p.tid"; | ||
| pub const DATADOG_TRACE_ID_KEY: &str = "x-datadog-trace-id"; | ||
| pub const DATADOG_ORIGIN_KEY: &str = "x-datadog-origin"; | ||
| pub const DATADOG_PARENT_ID_KEY: &str = "x-datadog-parent-id"; | ||
| pub const DATADOG_SAMPLING_PRIORITY_KEY: &str = "x-datadog-sampling-priority"; | ||
| pub const DATADOG_TAGS_KEY: &str = "x-datadog-tags"; | ||
| pub const DATADOG_PROPAGATION_ERROR_KEY: &str = "_dd.propagation_error"; |
There was a problem hiding this comment.
Let's keep them in the datadog namespace.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Exports the
datadogmodule and some constantsMotivation
Need to replace the code in the Datadog Lambda Extension (precursor of this module) to use this crate
Additional Notes
n/a