Skip to content

Conversation

iunanua
Copy link
Collaborator

@iunanua iunanua commented Sep 23, 2025

What does this PR do?

Get the id of the last RC update and use it to notify the configuration change via telemetry:

  • ApmTracingConfig struct modified to include the id field received in the RC response
  • RC tests changed accordingly
  • Add telemetry::notify_configuration_update method to notify the configuration change from the update_sampling_rules_from_remote and clear_remote_sampling_rules callbacks using the same config_id received previously

Motivation

Make pass some test_dynamic_configuration.py::TestDynamicConfigSamplingRules tests

Additional Notes

libdatadog's TelemetryWorkerHandle manages internally the configuration property changes. It stores the initial configuration values and it is able to know when a value has changed and to emit the app-client-configuration-change telemetry event.

Copy link

datadog-official bot commented Sep 23, 2025

✅ Tests

🎉 All green!

❄️ No new flaky tests detected
🧪 All tests passed

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 968c92b | Docs | Was this helpful? Give us feedback!

Base automatically changed from igor/fix-rc-rules-processing to main September 23, 2025 14:58
@iunanua iunanua marked this pull request as ready for review September 23, 2025 15:27
@iunanua iunanua requested a review from a team as a code owner September 23, 2025 15:27
@iunanua iunanua changed the title feat(remote_config): send RC updates via telemetry feat(remote_config): send RC updates via telemetry (sampling rules) Sep 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant