feat(remote_config): send RC updates via telemetry (sampling rules) #89
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Get the
id
of the last RC update and use it to notify the configuration change via telemetry:ApmTracingConfig
struct modified to include theid
field received in the RC responsetelemetry::notify_configuration_update
method to notify the configuration change from theupdate_sampling_rules_from_remote
andclear_remote_sampling_rules
callbacks using the same config_id received previouslyMotivation
Make pass some
test_dynamic_configuration.py::TestDynamicConfigSamplingRules
testsAdditional Notes
libdatadog's
TelemetryWorkerHandle
manages internally the configuration property changes. It stores the initial configuration values and it is able to know when a value has changed and to emit theapp-client-configuration-change
telemetry event.