-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Browser Monitoring Edits #14121
Browser Monitoring Edits #14121
Conversation
Updates "Browser RUM SDK" to "RUM Browser SDK" and small copy nits. Also adds some Further Reading links.
content/en/real_user_monitoring/browser/collecting_browser_errors.md
Outdated
Show resolved
Hide resolved
globs: | ||
- 'packages/rum/README.md' | ||
options: | ||
dest_path: '/real_user_monitoring/browser/' | ||
file_name: '_index.md' | ||
front_matters: | ||
dependencies: ["https://github.com/DataDog/browser-sdk/blob/main/packages/rum/README.md"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔨 warning: If I understand correctly, changing this URL will pull the README from your branch instead of main
. I think we should keep using main
, so it updates when we make a change, WDYT?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, this is just for the sake of the preview to connect the Browser Monitoring PR #1563 with!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❗ Information So this is the pull_config_preview.yaml
, the main site is pulled from the pull_config.yaml
file. We've split them out to keep this problem from happening! So you should definitely return the branch to main
, but even if it is merged in as-is, it won't be for production builds, just the preview sites. You should also always make sure to update both files with final changes.
What does this PR do?
Standardizes the naming of the "RUM Browser SDK" and small copy edits.
Motivation
#rum-docs Slack
Additional Notes
Remember to update the branch name in
pull_config.yaml
before merging!Reviewer checklist