Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Browser Monitoring Edits #14121

Merged
merged 4 commits into from
May 25, 2022
Merged

Conversation

alai97
Copy link
Contributor

@alai97 alai97 commented May 23, 2022

What does this PR do?

Standardizes the naming of the "RUM Browser SDK" and small copy edits.

Motivation

#rum-docs Slack

Additional Notes

Remember to update the branch name in pull_config.yaml before merging!


Reviewer checklist

  • Review the changed files.
  • Review the URLs listed in the Preview section.
  • Check images for PII
  • Review any mentions of "Contact Datadog support" for internal support documentation.

Updates "Browser RUM SDK" to "RUM Browser SDK" and small copy nits. Also adds some Further Reading links.
@alai97 alai97 requested review from a team as code owners May 23, 2022 23:41
@github-actions github-actions bot added Architecture Everything related to the Doc backend real_user_monitoring Content changed in the real_user_monitoring folder labels May 23, 2022
globs:
- 'packages/rum/README.md'
options:
dest_path: '/real_user_monitoring/browser/'
file_name: '_index.md'
front_matters:
dependencies: ["https://github.com/DataDog/browser-sdk/blob/main/packages/rum/README.md"]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔨 warning: ‏‏If I understand correctly, changing this URL will pull the README from your branch instead of main. I think we should keep using main, so it updates when we make a change, WDYT?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this is just for the sake of the preview to connect the Browser Monitoring PR #1563 with!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Information So this is the pull_config_preview.yaml, the main site is pulled from the pull_config.yaml file. We've split them out to keep this problem from happening! So you should definitely return the branch to main, but even if it is merged in as-is, it won't be for production builds, just the preview sites. You should also always make sure to update both files with final changes.

@alai97 alai97 merged commit 3d63fc6 into master May 25, 2022
@alai97 alai97 deleted the alai97/rum-browser-naming-batch-update branch May 25, 2022 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Architecture Everything related to the Doc backend real_user_monitoring Content changed in the real_user_monitoring folder
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants