Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DOCS-8435] NPM to CNM name change #25101

Merged
merged 32 commits into from
Dec 2, 2024
Merged

[DOCS-8435] NPM to CNM name change #25101

merged 32 commits into from
Dec 2, 2024

Conversation

aliciascott
Copy link
Contributor

What does this PR do? What is the motivation?

Merge instructions

  • Please merge after reviewing

Additional notes

@aliciascott
NPM to CNM name change

Verified

This commit was signed with the committer’s verified signature. The key has expired.
weihanglo Weihang Lo
GPG key ID: D7DBF189825E82E7
Expired
Verified
Learn about vigilant mode
Loading
Loading status checks…
97643c0
@aliciascott aliciascott requested a review from a team as a code owner September 5, 2024 19:42
@aliciascott aliciascott added the WORK IN PROGRESS No review needed, it's a wip ;) label Sep 5, 2024
@github-actions github-actions bot added Architecture Everything related to the Doc backend Guide Content impacting a guide labels Sep 5, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 5, 2024 •
edited
Loading

Preview links (active after the build_preview check completes)

New or renamed files

Removed or renamed files (these should redirect)

Renamed files

Modified Files

aliciascott and others added 6 commits September 7, 2024 10:32
@aliciascott
Merge branch 'master' into aliciascott/DOCS-8435-NPM-naming-change

Verified

This commit was signed with the committer’s verified signature.
spastorino Santiago Pastorino
GPG key ID: 8131A24E0C79EFAF
Verified
Learn about vigilant mode
Loading
Loading status checks…
b521a52
@aliciascott
Merge branch 'master' into aliciascott/DOCS-8435-NPM-naming-change
Loading
Loading status checks…
e0a1375
@aliciascott
testing
Loading
Loading status checks…
530241e
@aliciascott
fixing merge conflict
Loading
Loading status checks…
6406f3e
@aliciascott
updating NPM to CNM guides that I missed
Loading
Loading status checks…
b4d4276
@aliciascott
updating screenshots
Loading
Loading status checks…
b382cb7
@github-actions github-actions bot added the Images Images are added/removed with this PR label Sep 17, 2024
aliciascott and others added 6 commits September 19, 2024 14:16
@aliciascott
Merge branch 'master' into aliciascott/DOCS-8435-NPM-naming-change
Loading
Loading status checks…
3d72aa2 
merge master
@aliciascott
fixing merge conflicts
Loading
Loading status checks…
78cd5e4
@aliciascott
Merge branch 'master' into aliciascott/DOCS-8435-NPM-naming-change
Loading
Loading status checks…
fbf1b42
@aliciascott
Merge branch 'master' into aliciascott/DOCS-8435-NPM-naming-change

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
d406d30 
merging master into branch
@aliciascott
moar CNM updates

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
Loading
Loading status checks…
288fcdf
@aliciascott
Merge branch 'master' into aliciascott/DOCS-8435-NPM-naming-change

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
Loading
Loading status checks…
b8017ca
@aliciascott aliciascott mentioned this pull request Oct 24, 2024
Merged
4 tasks
aliciascott and others added 10 commits November 5, 2024 14:38
@aliciascott
fixing algolia tags

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
Loading
Loading status checks…
b2bf059
@aliciascott
Merge branch 'master' into aliciascott/DOCS-8435-NPM-naming-change

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
Loading
Loading status checks…
8dfef1c
@aliciascott
Merge branch 'master' into aliciascott/DOCS-8435-NPM-naming-change

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
Loading
Loading status checks…
299e6cb
@aliciascott
Merge branch 'master' into aliciascott/DOCS-8435-NPM-naming-change

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
Loading
Loading status checks…
2f4a37f
@aliciascott
fixing merge conflict from analytics page

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
Loading
Loading status checks…
79693d6
@aliciascott
Merge branch 'master' into aliciascott/DOCS-8435-NPM-naming-change
Loading
Loading status checks…
643c017
@aliciascott
fixing merge conflict
Loading
Loading status checks…
39c7eca
@aliciascott
updating screenshots with new UI design
Loading
Loading status checks…
df3a8bf
@aliciascott
fixing merge conflicts
Loading
Loading status checks…
d3766db
@aliciascott
fixing links on CCM page
Loading
Loading status checks…
9017312
cswatt
cswatt requested changes Nov 25, 2024
View reviewed changes
Copy link
Contributor

@cswatt cswatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mostly looks good!

aliciascott and others added 2 commits November 25, 2024 12:55
@aliciascott @cswatt
Apply suggestions from code review
Loading
Loading status checks…
741fb9b 
Co-authored-by: cecilia saixue watt <cecilia.watt@datadoghq.com>
@aliciascott
adding aliases to 2 guides
Loading
Loading status checks…
a44c62c
@aliciascott aliciascott requested a review from cswatt November 25, 2024 20:13
aliciascott and others added 3 commits November 27, 2024 11:08
@aliciascott
Merge branch 'master' into aliciascott/DOCS-8435-NPM-naming-change
Loading
Loading status checks…
be5db07
@aliciascott
updating other findings
Loading
Loading status checks…
1281171
@aliciascott
one moar
Loading
Loading status checks…
3b04e37
aliciascott and others added 2 commits December 2, 2024 08:42
@aliciascott @neko-dd
[DOCS-9444] adding failed connections to NPM setup page (#26221)
Loading
Loading status checks…
ff77ded 
* adding failed connections to NPM setup page

* Apply suggestions from code review

Co-authored-by: Sandra (neko) <165049174+neko-dd@users.noreply.github.com>

---------

Co-authored-by: Sandra (neko) <165049174+neko-dd@users.noreply.github.com>
@aliciascott
Merge branch 'master' into aliciascott/DOCS-8435-NPM-naming-change
Loading
Loading status checks…
57b3d3b 
merging master
@aliciascott
Copy link
Contributor Author

/merge

@dd-devflow
Copy link

dd-devflow bot commented Dec 2, 2024 •
edited
Loading

Devflow running: /merge

View all feedbacks in Devflow UI.

2024-12-02 15:58:51 UTC ℹ️ MergeQueue: waiting for PR to be ready

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.

2024-12-02 16:03:00 UTC ℹ️ MergeQueue: merge request added to the queue

The median merge time in master is 7m.

@dd-mergequeue dd-mergequeue bot merged commit bff4bff into master Dec 2, 2024
18 of 20 checks passed
@dd-mergequeue dd-mergequeue bot deleted the aliciascott/DOCS-8435-NPM-naming-change branch December 2, 2024 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cswatt cswatt

Assignees
No one assigned
Labels
Architecture Everything related to the Doc backend Guide Content impacting a guide Images Images are added/removed with this PR mergequeue-status: done WORK IN PROGRESS No review needed, it's a wip ;)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@aliciascott @cswatt