Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a note on CI runs not triggering s8s monitors #26438

Merged
merged 3 commits into from
Nov 22, 2024

Conversation

marcadev-fc
Copy link
Contributor

What does this PR do? What is the motivation?

Making this docs change so that users are aware that CI failed runs don't factor into a synthetics test's monitor evaluation.

Merge instructions

Merge queue is enabled in this repo. To have it automatically merged after it receives the required reviews, create the PR (from a branch that follows the <yourname>/description naming convention) and then add the following PR comment:

/merge

Additional notes

@marcadev-fc marcadev-fc requested review from a team as code owners November 22, 2024 10:43
Copy link
Contributor

Preview links (active after the build_preview check completes)

Modified Files

Copy link
Contributor

@drichards-87 drichards-87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some light feedback on the PR.

content/en/continuous_testing/troubleshooting.md Outdated Show resolved Hide resolved
content/en/continuous_testing/troubleshooting.md Outdated Show resolved Hide resolved
marcadev-fc and others added 2 commits November 22, 2024 18:09
Co-authored-by: DeForest Richards <56796055+drichards-87@users.noreply.github.com>
Co-authored-by: DeForest Richards <56796055+drichards-87@users.noreply.github.com>
@marcadev-fc
Copy link
Contributor Author

/merge

@dd-devflow
Copy link

dd-devflow bot commented Nov 22, 2024

Devflow running: /merge

View all feedbacks in Devflow UI.


2024-11-22 17:32:50 UTC ℹ️ MergeQueue: pull request added to the queue

The median merge time in master is 11m.

@dd-mergequeue dd-mergequeue bot merged commit bda4914 into master Nov 22, 2024
16 of 19 checks passed
@dd-mergequeue dd-mergequeue bot deleted the adam.ghaoul/update-CT-troubleshooting-docs branch November 22, 2024 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants