Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update oauth_for_integrations.md #26448

Merged
merged 3 commits into from
Nov 22, 2024
Merged

Conversation

eho1307
Copy link
Contributor

@eho1307 eho1307 commented Nov 22, 2024

Adding two additional clarifications

Merge instructions

Please merge once approved

Merge queue is enabled in this repo. To have it automatically merged after it receives the required reviews, create the PR (from a branch that follows the <yourname>/description naming convention) and then add the following PR comment:

/merge

Additional notes

Adding two additional clarifications
@eho1307 eho1307 requested review from a team as code owners November 22, 2024 15:57
Copy link
Contributor

Preview links (active after the build_preview check completes)

Modified Files

Copy link
Contributor

@drichards-87 drichards-87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some minor feedback on the PR.

eho1307 and others added 2 commits November 22, 2024 13:59
Co-authored-by: DeForest Richards <56796055+drichards-87@users.noreply.github.com>
Co-authored-by: DeForest Richards <56796055+drichards-87@users.noreply.github.com>
@eho1307 eho1307 requested a review from drichards-87 November 22, 2024 18:59
@eho1307
Copy link
Contributor Author

eho1307 commented Nov 22, 2024

@drichards-87 could you help me merge this?

@drichards-87
Copy link
Contributor

@eho1307 Yep, no worries. I'll take care of that for you now.

Also, as an FYI, we recently enabled merge queue on the documentation repo. After you get the required approvals, you can add a comment with /merge to a PR, and it will automatically merge the PR.

@drichards-87
Copy link
Contributor

/merge

@dd-devflow
Copy link

dd-devflow bot commented Nov 22, 2024

Devflow running: /merge

View all feedbacks in Devflow UI.


2024-11-22 19:57:08 UTC ℹ️ MergeQueue: pull request added to the queue

The median merge time in master is 10m.

@dd-mergequeue dd-mergequeue bot merged commit bc50c5f into master Nov 22, 2024
17 of 20 checks passed
@dd-mergequeue dd-mergequeue bot deleted the eho1307/oauth-integrations-1 branch November 22, 2024 20:05
theraffoul pushed a commit that referenced this pull request Nov 25, 2024
* Update oauth_for_integrations.md

Adding two additional clarifications

* Update content/en/developers/integrations/oauth_for_integrations.md

Co-authored-by: DeForest Richards <56796055+drichards-87@users.noreply.github.com>

* Update content/en/developers/integrations/oauth_for_integrations.md

Co-authored-by: DeForest Richards <56796055+drichards-87@users.noreply.github.com>

---------

Co-authored-by: DeForest Richards <56796055+drichards-87@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants