-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update DD_TRACE_PROPAGATION_STYLE default values #28583
base: master
Are you sure you want to change the base?
Conversation
Preview links (active after the
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Aside from this page, there are a handful of other pages that should be updated as well
@duncanhewett how would you like us to handle those? Would you suggest we just update them for now, have them link to the main trace context propagation page, or something else?
**Default**: `datadog,tracecontext` <br> | ||
**Note**: With multiple formats, extraction follows the specified order (for example, `datadog,tracecontext` checks Datadog headers first). The first valid context continues the trace; additional valid contexts become span links. | ||
**Default**: `datadog,tracecontext,baggage` <br> | ||
**Note**: With multiple formats, extraction follows the specified order (for example, `datadog,tracecontext,baggage` checks Datadog headers first). The first valid context continues the trace; additional valid contexts become span links. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will need to be rephrased a bit to include baggage
**Note**: With multiple formats, extraction follows the specified order (for example, `datadog,tracecontext,baggage` checks Datadog headers first). The first valid context continues the trace; additional valid contexts become span links. | |
**Note**: With multiple trace context formats, extraction follows the specified order (for example, `datadog,tracecontext` checks Datadog headers first). The first valid context continues the trace; additional valid contexts become span links. When `baggage` is included, it is added as [baggage](#baggage) to the existing context. |
Created DOCS-10563 for docs team review |
I would just update them for now. I do think the configuration should remain documented on each SDK page but it would good to find a way to avoid the duplication of the content in the codebase to make maintenance easier. |
What does this PR do? What is the motivation?
Update DD_TRACE_PROPAGATION_STYLE default values to include baggage.
Merge instructions
Merge readiness:
For Datadog employees:
Merge queue is enabled in this repo. Your branch name MUST follow the
<name>/<description>
convention and include the forward slash (/
). Without this format, your pull request will not pass in CI, the GitLab pipeline will not run, and you won't get a branch preview. Getting a branch preview makes it easier for us to check any issues with your PR, such as broken links.If your branch doesn't follow this format, rename it or create a new branch and PR.
To have your PR automatically merged after it receives the required reviews, add the following PR comment:
Additional notes