-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Update versioning docs for dd-trace-py #28968
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Preview links (active after the
|
duncanhewett
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added a couple of suggestions
Co-authored-by: Duncan Hewett <duncanhewett@users.noreply.github.com>
Co-authored-by: Brett Blue <84536271+brett0000FF@users.noreply.github.com>
|
/merge |
|
View all feedbacks in Devflow UI.
This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
The expected merge time in
|
Remove duplicate content that will be migrated to the public docs. PR to update the public docs: DataDog/documentation#28968 ## Checklist - [x] PR author has checked that all the criteria below are met - The PR description includes an overview of the change - The PR description articulates the motivation for the change - The change includes tests OR the PR description describes a testing strategy - The PR description notes risks associated with the change, if any - Newly-added code is easy to change - The change follows the [library release note guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html) - The change includes or references documentation updates if necessary - Backport labels are set (if [applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)) ## Reviewer Checklist - [x] Reviewer has checked that all the criteria below are met - Title is accurate - All changes are related to the pull request's stated goal - Avoids breaking [API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces) changes - Testing strategy adequately addresses listed risks - Newly-added code is easy to change - Release note makes sense to a user of the library - If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment - Backport labels are set in a manner that is consistent with the [release branch maintenance policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)
Remove duplicate content that will be migrated to the public docs. PR to update the public docs: DataDog/documentation#28968 ## Checklist - [x] PR author has checked that all the criteria below are met - The PR description includes an overview of the change - The PR description articulates the motivation for the change - The change includes tests OR the PR description describes a testing strategy - The PR description notes risks associated with the change, if any - Newly-added code is easy to change - The change follows the [library release note guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html) - The change includes or references documentation updates if necessary - Backport labels are set (if [applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)) ## Reviewer Checklist - [x] Reviewer has checked that all the criteria below are met - Title is accurate - All changes are related to the pull request's stated goal - Avoids breaking [API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces) changes - Testing strategy adequately addresses listed risks - Newly-added code is easy to change - Release note makes sense to a user of the library - If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment - Backport labels are set in a manner that is consistent with the [release branch maintenance policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)
* update versioning for ddtracepy * Update content/en/tracing/trace_collection/compatibility/python.md Co-authored-by: Duncan Hewett <duncanhewett@users.noreply.github.com> * Update content/en/tracing/trace_collection/compatibility/python.md * Update content/en/tracing/trace_collection/compatibility/python.md * Update content/en/tracing/trace_collection/compatibility/python.md Co-authored-by: Brett Blue <84536271+brett0000FF@users.noreply.github.com> * Update content/en/tracing/trace_collection/compatibility/python.md * Update content/en/tracing/trace_collection/compatibility/python.md * Update content/en/tracing/trace_collection/compatibility/python.md --------- Co-authored-by: Duncan Hewett <duncanhewett@users.noreply.github.com> Co-authored-by: Brett Blue <84536271+brett0000FF@users.noreply.github.com>
What does this PR do? What is the motivation?
The versioning docs for dd-trace-py haven't been updated for 3 years. This is the start of a larger process to migrate our contributor/readthedocs docs over to the public docs as much as possible.
Once this is merged, we will merge a subsequent PR on the dd-trace-py side to delete the duplicate information and just provide a link to the public docs instead (DataDog/dd-trace-py#13269).
Merge instructions
Merge readiness:
For Datadog employees:
Merge queue is enabled in this repo. Your branch name MUST follow the
<name>/<description>convention and include the forward slash (/). Without this format, your pull request will not pass in CI, the GitLab pipeline will not run, and you won't get a branch preview. Getting a branch preview makes it easier for us to check any issues with your PR, such as broken links.If your branch doesn't follow this format, rename it or create a new branch and PR.
To have your PR automatically merged after it receives the required reviews, add the following PR comment:
Additional notes