Skip to content

Conversation

@erikayasuda
Copy link
Contributor

@erikayasuda erikayasuda commented Apr 24, 2025

What does this PR do? What is the motivation?

The versioning docs for dd-trace-py haven't been updated for 3 years. This is the start of a larger process to migrate our contributor/readthedocs docs over to the public docs as much as possible.

Once this is merged, we will merge a subsequent PR on the dd-trace-py side to delete the duplicate information and just provide a link to the public docs instead (DataDog/dd-trace-py#13269).

Merge instructions

Merge readiness:

  • Ready for merge

For Datadog employees:
Merge queue is enabled in this repo. Your branch name MUST follow the <name>/<description> convention and include the forward slash (/). Without this format, your pull request will not pass in CI, the GitLab pipeline will not run, and you won't get a branch preview. Getting a branch preview makes it easier for us to check any issues with your PR, such as broken links.

If your branch doesn't follow this format, rename it or create a new branch and PR.

To have your PR automatically merged after it receives the required reviews, add the following PR comment:

/merge

Additional notes

@erikayasuda erikayasuda requested a review from a team as a code owner April 24, 2025 20:48
@erikayasuda erikayasuda requested a review from mabdinur April 24, 2025 20:48
@github-actions
Copy link
Contributor

Preview links (active after the build_preview check completes)

Modified Files

@cswatt cswatt self-assigned this Apr 24, 2025
Copy link
Contributor

@duncanhewett duncanhewett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a couple of suggestions

Co-authored-by: Duncan Hewett <duncanhewett@users.noreply.github.com>
Co-authored-by: Brett Blue <84536271+brett0000FF@users.noreply.github.com>
@erikayasuda
Copy link
Contributor Author

/merge

@dd-devflow
Copy link

dd-devflow bot commented Apr 29, 2025

View all feedbacks in Devflow UI.

2025-04-29 21:34:39 UTC ℹ️ Start processing command /merge


2025-04-29 21:34:45 UTC ℹ️ MergeQueue: waiting for PR to be ready

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.


2025-04-29 22:03:16 UTC ℹ️ MergeQueue: merge request added to the queue

The expected merge time in master is approximately 20m (p90).


2025-04-29 22:20:09 UTC ℹ️ MergeQueue: This merge request was merged

@dd-mergequeue dd-mergequeue bot merged commit de89436 into master Apr 29, 2025
17 of 21 checks passed
@dd-mergequeue dd-mergequeue bot deleted the erikayasuda/python-versioning branch April 29, 2025 22:20
erikayasuda added a commit to DataDog/dd-trace-py that referenced this pull request Apr 30, 2025
Remove duplicate content that will be migrated to the public docs.

PR to update the public docs:
DataDog/documentation#28968

## Checklist
- [x] PR author has checked that all the criteria below are met
- The PR description includes an overview of the change
- The PR description articulates the motivation for the change
- The change includes tests OR the PR description describes a testing
strategy
- The PR description notes risks associated with the change, if any
- Newly-added code is easy to change
- The change follows the [library release note
guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html)
- The change includes or references documentation updates if necessary
- Backport labels are set (if
[applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting))

## Reviewer Checklist
- [x] Reviewer has checked that all the criteria below are met 
- Title is accurate
- All changes are related to the pull request's stated goal
- Avoids breaking
[API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces)
changes
- Testing strategy adequately addresses listed risks
- Newly-added code is easy to change
- Release note makes sense to a user of the library
- If necessary, author has acknowledged and discussed the performance
implications of this PR as reported in the benchmarks PR comment
- Backport labels are set in a manner that is consistent with the
[release branch maintenance
policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)
brettlangdon pushed a commit to DataDog/dd-trace-py that referenced this pull request May 6, 2025
Remove duplicate content that will be migrated to the public docs.

PR to update the public docs:
DataDog/documentation#28968

## Checklist
- [x] PR author has checked that all the criteria below are met
- The PR description includes an overview of the change
- The PR description articulates the motivation for the change
- The change includes tests OR the PR description describes a testing
strategy
- The PR description notes risks associated with the change, if any
- Newly-added code is easy to change
- The change follows the [library release note
guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html)
- The change includes or references documentation updates if necessary
- Backport labels are set (if
[applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting))

## Reviewer Checklist
- [x] Reviewer has checked that all the criteria below are met 
- Title is accurate
- All changes are related to the pull request's stated goal
- Avoids breaking
[API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces)
changes
- Testing strategy adequately addresses listed risks
- Newly-added code is easy to change
- Release note makes sense to a user of the library
- If necessary, author has acknowledged and discussed the performance
implications of this PR as reported in the benchmarks PR comment
- Backport labels are set in a manner that is consistent with the
[release branch maintenance
policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)
estherk15 pushed a commit that referenced this pull request May 8, 2025
* update versioning for ddtracepy

* Update content/en/tracing/trace_collection/compatibility/python.md

Co-authored-by: Duncan Hewett <duncanhewett@users.noreply.github.com>

* Update content/en/tracing/trace_collection/compatibility/python.md

* Update content/en/tracing/trace_collection/compatibility/python.md

* Update content/en/tracing/trace_collection/compatibility/python.md

Co-authored-by: Brett Blue <84536271+brett0000FF@users.noreply.github.com>

* Update content/en/tracing/trace_collection/compatibility/python.md

* Update content/en/tracing/trace_collection/compatibility/python.md

* Update content/en/tracing/trace_collection/compatibility/python.md

---------

Co-authored-by: Duncan Hewett <duncanhewett@users.noreply.github.com>
Co-authored-by: Brett Blue <84536271+brett0000FF@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants