Moving confusing docker param from main setup page #3114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cswatt
approved these changes
Sep 10, 2018
gbbr
reviewed
Sep 10, 2018
| | `DD_IGNORE_RESOURCE` | A comma-separated list of resources that the Agent should ignore. | | ||
| | `DD_LOG_LEVEL` | Set the logging level. | | ||
| | `DD_APM_ANALYZED_SPANS` | Configure the spans to analyze for transactions. | | ||
| | `DD_CONNECTION_LIMIT` | Set the Limit of unique connections . | |
There was a problem hiding this comment.
You might want to lower case "limit" and remove the space before the period at the end of the sentence.
| | `DD_DOGSTATSD_PORT` | Set the DogStatsD port. | | ||
| | `DD_APM_NON_LOCAL_TRAFFIC` | Allow non-local traffic when [tracing from other containers](#tracing-from-other-containers). | | ||
| | `DD_IGNORE_RESOURCE` | A comma-separated list of resources that the Agent should ignore. | | ||
| | `DD_LOG_LEVEL` | Set the logging level. | |
There was a problem hiding this comment.
Make a parenthesis and give an example of possible values. You can see them here
LotharSee
reviewed
Sep 10, 2018
| | `apm_non_local_traffic` | boolean | Allows the Agent to receive outside connections. It then listen on all interfaces. | | ||
| | `max_memory` | float | Maximum memory that the Agent is allowed to occupy. When this is exceeded the process is killed. | | ||
| | `max_cpu_percent` | float | Maximum CPU percentage that the Agent should use. The Agent automatically adjusts its pre-sampling rate to stay below this number. | | ||
| | `max_connections` | number | Maximum number of network connections that the Agent is allowed to use. When this is exceeded the process is killed. | |
There was a problem hiding this comment.
This is an option we deprecated, we'd like to remove it from the public documentation.
There was a problem hiding this comment.
Same with DD_CONNECTION_LIMIT
There was a problem hiding this comment.
Created DataDog/datadog-trace-agent#469 to ensure this is clear moving forward
There was a problem hiding this comment.
PR to fix this: #3123
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Moves docker parameter to the dedicated tracing/setup/docker page
Motivation
A customer was confused
Preview link