Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Rails logging configuration for Ruby APM correlation #3783

Merged
merged 3 commits into from
Jan 21, 2019

Conversation

delner
Copy link
Contributor

@delner delner commented Jan 16, 2019

What does this PR do?

Adds another example of configuring Ruby APM with correlation IDs for Rails logging.

Motivation

Make it clearer for our Rails users how to activate this in the simplest possible manner.

Preview link

https://docs-staging.datadoghq.com/delner/apm_ruby_add_rails_log_example/tracing/languages/ruby/

Additional Notes

Describes DataDog/dd-trace-rb#673

@delner delner added the Tracing label Jan 16, 2019
@delner delner self-assigned this Jan 16, 2019
@delner delner requested a review from l0k0ms January 16, 2019 23:06
@delner delner requested review from mstbbs and a team as code owners January 16, 2019 23:06
@delner delner force-pushed the delner/apm_ruby_add_rails_log_example branch from 15bd15e to added73 Compare January 17, 2019 13:18
@delner delner force-pushed the delner/apm_ruby_add_rails_log_example branch from added73 to bbcf659 Compare January 17, 2019 15:15
Copy link
Contributor

@l0k0ms l0k0ms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👌

@l0k0ms l0k0ms merged commit 8923136 into master Jan 21, 2019
@l0k0ms l0k0ms deleted the delner/apm_ruby_add_rails_log_example branch January 21, 2019 06:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants