Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

apm/python: update links #8469

Merged
merged 5 commits into from
Oct 8, 2020
Merged

apm/python: update links #8469

merged 5 commits into from
Oct 8, 2020

Conversation

Kyle-Verhoog
Copy link
Member

What does this PR do?

Updates the links in the docs for when DataDog/dd-trace-py#1635 is merged and deployed.

@Kyle-Verhoog Kyle-Verhoog added the WORK IN PROGRESS No review needed, it's a wip ;) label Sep 4, 2020
@Kyle-Verhoog Kyle-Verhoog requested a review from a team as a code owner September 4, 2020 17:45
@github-actions github-actions bot added the tracing Content changed in the tracing folder label Sep 4, 2020
@Kyle-Verhoog Kyle-Verhoog mentioned this pull request Sep 4, 2020
Merged
1 task
@Kyle-Verhoog Kyle-Verhoog removed the WORK IN PROGRESS No review needed, it's a wip ;) label Oct 5, 2020
@Kyle-Verhoog
Copy link
Member Author

@DataDog/documentation could someone please review this? We'll be updating our docs with our next release and these links need to be updated 🙂

@kayayarai kayayarai self-requested a review October 5, 2020 22:17
kayayarai
kayayarai approved these changes Oct 5, 2020
View reviewed changes
Copy link
Collaborator

@kayayarai kayayarai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Let me know when the links go live and we can merge.

@Kyle-Verhoog
Copy link
Member Author

thanks @kayayarai!

@Kyle-Verhoog Kyle-Verhoog mentioned this pull request Oct 8, 2020
Merged
3 tasks
@github-actions github-actions bot added account_management Content changed in the Account_management folder Guide Content impacting a guide logs Content changed in the log folder labels Oct 8, 2020
@Kyle-Verhoog Kyle-Verhoog removed account_management Content changed in the Account_management folder logs Content changed in the log folder Guide Content impacting a guide labels Oct 8, 2020
@Kyle-Verhoog
Copy link
Member Author

Heh I made a bit of a mess by merging locally (and having the precommit hooks run over all the merged files). Cleaned up now 😆.

@kayayarai we'll be releasing later today. I'll let you know when so we can merge 🙂

@Kyle-Verhoog
Copy link
Member Author

@kayayarai we just released so this can be merged now, thanks! 😄

@kayayarai kayayarai merged commit 01d3d59 into master Oct 8, 2020
@kayayarai kayayarai deleted the kyle/ddtrace branch October 8, 2020 20:03
@kayayarai
Copy link
Collaborator

@Kyle-Verhoog So you're aware, the translation build will overwrite these changes in the ja and fr (some happened last night), but they'll get re-applied when the translation of these pages catches up to the English source. Our fr and ja content origin is transifex, not github

@Kyle-Verhoog
Copy link
Member Author

Oh I see. Hmm I'll see if we can provide redirects for the links in the mean-time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kayayarai kayayarai kayayarai approved these changes

@andrewardito andrewardito Awaiting requested review from andrewardito

Assignees
No one assigned
Labels
tracing Content changed in the tracing folder
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Kyle-Verhoog @kayayarai