Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[connection] clearer connection design and retry mechanism. #204

Merged
merged 5 commits into from
Sep 28, 2021
Merged

[connection] clearer connection design and retry mechanism. #204

merged 5 commits into from
Sep 28, 2021

Conversation

remeh
Copy link
Contributor

@remeh remeh commented Sep 10, 2021 •
edited
Loading

Every connection implementation (UDP or UDS) is owning its actual @socket connection.

Interface with the parent Connection is limited to #close, #connect and #send_message for the retry mechanism.

@remeh remeh mentioned this pull request Sep 10, 2021
Closed
ivoanjo
ivoanjo reviewed Sep 14, 2021
View reviewed changes
Copy link
Member

@ivoanjo ivoanjo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few notes, thanks for splitting this from the other changes, really easy to review :)

lib/datadog/statsd/uds_connection.rb Outdated Show resolved Hide resolved
lib/datadog/statsd/uds_connection.rb Outdated Show resolved Hide resolved
lib/datadog/statsd/connection.rb Show resolved Hide resolved
spec/statsd_spec.rb Outdated Show resolved Hide resolved
ivoanjo
ivoanjo approved these changes Sep 17, 2021
View reviewed changes
Copy link
Member

@ivoanjo ivoanjo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@remeh
Copy link
Contributor Author

remeh commented Sep 28, 2021

Thanks for the review @ivoanjo 🙇

@remeh remeh merged commit db72b90 into master Sep 28, 2021
@remeh remeh deleted the remeh/connection branch September 28, 2021 11:28
@remeh remeh modified the milestone: Next Sep 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ivoanjo ivoanjo ivoanjo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@remeh @ivoanjo