Drop support for Ruby before 2.1.0 #229
Conversation
|
#230 seems to be showing that at least one of our deps has a transitive dep on a version of webrick not available in Ruby-2.0. |
There was a problem hiding this comment.
👍 Support for 2.0 has already been dropped by https://github.com/DataDog/dd-trace-rb/releases/tag/v0.50.0 in Jun 2021.
There was a problem hiding this comment.
LGTM.
Gems tend to drop Ruby versions in major releases, and note that a while back I've added this section in the README: https://github.com/DataDog/dogstatsd-ruby#versioning for us to be able to use a minor if we would prefer (we may drop multiple versions of Ruby in the future and we probably won't want to have multiple majors of dogstatsd-ruby).
I think we should mention somewhere (in the CHANGELOG update?) which version of dogstatsd-ruby is the last one to support Ruby 2.0. WDYT?
If you go this way, we have an example of listing support for older Rubies in the documentation: https://github.com/DataDog/dd-trace-rb/blob/279ff50/docs/GettingStarted.md#compatibility. The matrix will likely be more simplified here, but I wanted to show you what we are doing today, in case it helps. |
|
dogstatsd-ruby/lib/datadog/statsd.rb Lines 107 to 109 in ed04ca4 |
Fixes #228.