-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tests for private action runner helm chart #1532
Merged
dd-gplassard
merged 10 commits into
main
from
gabriel.plassard/WF-9346/improve-private-actions-helm-tests
Sep 26, 2024
Merged
Tests for private action runner helm chart #1532
dd-gplassard
merged 10 commits into
main
from
gabriel.plassard/WF-9346/improve-private-actions-helm-tests
Sep 26, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
Base automatically changed from
gabriel.plassard/WF-9346/improve-private-actions-helm
to
main
September 24, 2024 08:34
f8e892a
to
6acec8d
Compare
This reverts commit 04de79e.
1c113e3
to
a6d171c
Compare
oliverli
approved these changes
Sep 26, 2024
levan-m
approved these changes
Sep 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
I initially wanted to do it in #1529 but I found out that my implementation
was only making assertions on the service-account, all other resources were not checked. I believe this is due to the fact that
common.Unmarshal(t, manifest, &actual)
andcommon.LoadFromFile(t, baselineManifestPath, &baseline)
actually only read the first entry from the yaml and ignores the following ones (not 100% sure about this but it matches my observation)helm-charts/test/private-action-runner/baseline_test.go
Lines 67 to 81 in 8a47e13
helm-charts/test/private-action-runner/baseline/Private_Action_Runner_default.yaml
Lines 1 to 27 in 8a47e13
the tests were not running on the pull request because the only github workflow running unit test is restricted to
test/datadog-operator/**
andcharts/datadog-operator/**
pathsSpecial notes for your reviewer:
I'm not 100% sure of the best path forward about this.
helm.DiffAgainstSnapshot
which made bump a few dependencies.It also seems like tests from other packages are also not working so not sure what we should do about them.This is fixed