Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NDM] [Cisco ACI] Support submitting topology metadata #18675

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

zoedt
Copy link
Contributor

@zoedt zoedt commented Sep 26, 2024

What does this PR do?

https://datadoghq.atlassian.net/browse/NDMII-2989

Adds support for sending TopologyLinkMetadata to our EvP ndm track to support having ACI devices appear on the topology map.

See this document for additional context.

Motivation

Additional Notes

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Changelog entries must be created for modifications to shipped code
  • Add the qa/skip-qa label if the PR doesn't need to be tested during QA.
  • If you need to backport this PR to another branch, you can add the backport/<branch-name> label to the PR and it will automatically open a backport PR once this one is merged

@zoedt zoedt changed the title [NDM] [Cisco ACI] Support topology metadata [NDM] [Cisco ACI] Support submitting topology metadata Sep 26, 2024
Copy link

codecov bot commented Sep 26, 2024

Codecov Report

Attention: Patch coverage is 96.22642% with 4 lines in your changes missing coverage. Please review.

Project coverage is 89.54%. Comparing base (2a9e54a) to head (7f71145).
Report is 21 commits behind head on master.

Additional details and impacted files
Flag Coverage Δ
activemq ?
cassandra ?
cisco_aci 89.83% <96.22%> (+0.24%) ⬆️
hive ?
hivemq ?
hudi ?
ignite ?
jboss_wildfly ?
kafka ?
kubevirt_handler ?
presto ?
solr ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants